Bug 34056 - authorised-values API client file is missing -api-client suffix
Summary: authorised-values API client file is missing -api-client suffix
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32983
Blocks: 34055
  Show dependency treegraph
 
Reported: 2023-06-19 08:13 UTC by Jonathan Druart
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.03,22.11.09


Attachments
Bug 34056: Add -api-client suffit to authorised-values API client (1.93 KB, patch)
2023-06-19 08:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 34056: Add -api-client suffit to authorised-values API client (2.01 KB, patch)
2023-07-17 09:02 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34056: Add -api-client suffit to authorised-values API client (2.05 KB, patch)
2023-07-29 21:41 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-19 08:13:33 UTC
In koha-tmpl/intranet-tmpl/prog/js/vue/fetch all files have the -api-client suffix but authorised-values. For consistency we should add it.
Comment 1 Jonathan Druart 2023-06-19 08:17:41 UTC
Created attachment 152469 [details] [review]
Bug 34056: Add -api-client suffit to authorised-values API client

In koha-tmpl/intranet-tmpl/prog/js/vue/fetch all files have the -api-client suffix but authorised-values. For consistency we should add it.

Test plan:
Go to the ERM module and confirm that dropdown lists are correctly
filled in with authorised values.
You can also inspect the console and confirm that a GET query to /authorised_value_categories is done

Sponsored-by: BULAC - http://www.bulac.fr/
Comment 2 Matt Blenkinsop 2023-07-17 09:02:43 UTC
Created attachment 153531 [details] [review]
Bug 34056: Add -api-client suffit to authorised-values API client

In koha-tmpl/intranet-tmpl/prog/js/vue/fetch all files have the -api-client suffix but authorised-values. For consistency we should add it.

Test plan:
Go to the ERM module and confirm that dropdown lists are correctly
filled in with authorised values.
You can also inspect the console and confirm that a GET query to /authorised_value_categories is done

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-07-29 21:41:56 UTC
Created attachment 154072 [details] [review]
Bug 34056: Add -api-client suffit to authorised-values API client

In koha-tmpl/intranet-tmpl/prog/js/vue/fetch all files have the -api-client suffix but authorised-values. For consistency we should add it.

Test plan:
Go to the ERM module and confirm that dropdown lists are correctly
filled in with authorised values.
You can also inspect the console and confirm that a GET query to /authorised_value_categories is done

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-08-15 08:24:32 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-17 19:27:46 UTC
Pushed to 23.05.x for 23.05.03
Comment 6 Pedro Amorim 2023-08-18 13:46:15 UTC
Nice work everyone!

Pushed to 22.11.x for next release