Summary: | Responsive table button icon broken after FontAwesome upgrade | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | 32910 | ||
Bug Blocks: | |||
Attachments: |
Bug 34129: Fix plus and minus icon
[ALTERNATE] Bug 34129: Fix plus and minus icon Bug 34129: Fix plus and minus icon Bug 34129: Fix plus and minus icon Bug 34129: Fix plus and minus icon |
Description
Owen Leonard
2023-06-27 11:48:41 UTC
Created attachment 153055 [details] [review] Bug 34129: Fix plus and minus icon Is this... bad? Created attachment 153056 [details] [review] [ALTERNATE] Bug 34129: Fix plus and minus icon (In reply to Jonathan Druart from comment #3) > Created attachment 153056 [details] [review] [review] > [ALTERNATE] Bug 34129: Fix plus and minus icon This seems to work for me. (In reply to Jonathan Druart from comment #4) > This seems to work for me. Sorry it's not working for me. The icons are still blank even after regenerating the CSS. Created attachment 153063 [details] [review] Bug 34129: Fix plus and minus icon (In reply to Owen Leonard from comment #5) > (In reply to Jonathan Druart from comment #4) > > This seems to work for me. > > Sorry it's not working for me. The icons are still blank even after > regenerating the CSS. I didn't commit the latest change, sorry! Created attachment 154497 [details] [review] Bug 34129: Fix plus and minus icon This patch fixes the plus and minus on the buttons to expand the columns in mobile or zoomed in view. To test: 1. Apply the patch 2. Rebuild css (yarn build) 3. Go to the OPAC and search for a record with an item 4. Zoom in to 400% or change view to mobile --> The items table should have a plus (+) button in the last column to expand and have the rest of the information Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> It wasn't at need signoff, but I tried and it works well. Also added a test plan. Thanks Jonathan! *** Bug 34485 has been marked as a duplicate of this bug. *** Fixing the issue nicely. Wondering: should or could we have an alt text on this button? Created attachment 154804 [details] [review] Bug 34129: Fix plus and minus icon This patch fixes the plus and minus on the buttons to expand the columns in mobile or zoomed in view. To test: 1. Apply the patch 2. Rebuild css (yarn build) 3. Go to the OPAC and search for a record with an item 4. Zoom in to 400% or change view to mobile --> The items table should have a plus (+) button in the last column to expand and have the rest of the information Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Depends on Bug 32910 not in 23.05.x |