The plus/minus buttons that appear in place of responsively-hidden columns in the OPAC are broken after the FontAwesome upgrade. The icons don't appear anymore. I though the issue was with the Unicode defined in _common.scss, and while replacing 'content: "\f067";' with 'content: "\2b";' works for the "plus" button, the "minus" button stays broken no matter what Unicode I plug in.
Created attachment 153055 [details] [review] Bug 34129: Fix plus and minus icon
Is this... bad?
Created attachment 153056 [details] [review] [ALTERNATE] Bug 34129: Fix plus and minus icon
(In reply to Jonathan Druart from comment #3) > Created attachment 153056 [details] [review] [review] > [ALTERNATE] Bug 34129: Fix plus and minus icon This seems to work for me.
(In reply to Jonathan Druart from comment #4) > This seems to work for me. Sorry it's not working for me. The icons are still blank even after regenerating the CSS.
Created attachment 153063 [details] [review] Bug 34129: Fix plus and minus icon
(In reply to Owen Leonard from comment #5) > (In reply to Jonathan Druart from comment #4) > > This seems to work for me. > > Sorry it's not working for me. The icons are still blank even after > regenerating the CSS. I didn't commit the latest change, sorry!
Created attachment 154497 [details] [review] Bug 34129: Fix plus and minus icon This patch fixes the plus and minus on the buttons to expand the columns in mobile or zoomed in view. To test: 1. Apply the patch 2. Rebuild css (yarn build) 3. Go to the OPAC and search for a record with an item 4. Zoom in to 400% or change view to mobile --> The items table should have a plus (+) button in the last column to expand and have the rest of the information Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
It wasn't at need signoff, but I tried and it works well. Also added a test plan. Thanks Jonathan!
*** Bug 34485 has been marked as a duplicate of this bug. ***
Fixing the issue nicely. Wondering: should or could we have an alt text on this button?
Created attachment 154804 [details] [review] Bug 34129: Fix plus and minus icon This patch fixes the plus and minus on the buttons to expand the columns in mobile or zoomed in view. To test: 1. Apply the patch 2. Rebuild css (yarn build) 3. Go to the OPAC and search for a record with an item 4. Zoom in to 400% or change view to mobile --> The items table should have a plus (+) button in the last column to expand and have the rest of the information Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 32910 not in 23.05.x