Bug 34129 - Responsive table button icon broken after FontAwesome upgrade
Summary: Responsive table button icon broken after FontAwesome upgrade
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords:
: 34485 (view as bug list)
Depends on: 32910
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-27 11:48 UTC by Owen Leonard
Modified: 2023-08-30 06:45 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34129: Fix plus and minus icon (1.38 KB, patch)
2023-07-05 12:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
[ALTERNATE] Bug 34129: Fix plus and minus icon (1.64 KB, patch)
2023-07-05 12:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 34129: Fix plus and minus icon (2.14 KB, patch)
2023-07-05 15:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 34129: Fix plus and minus icon (2.57 KB, patch)
2023-08-17 08:23 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 34129: Fix plus and minus icon (2.62 KB, patch)
2023-08-25 11:59 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-27 11:48:41 UTC
The plus/minus buttons that appear in place of responsively-hidden columns in the OPAC are broken after the FontAwesome upgrade. The icons don't appear anymore.

I though the issue was with the Unicode defined in _common.scss, and while replacing 'content: "\f067";' with 'content: "\2b";' works for the "plus" button, the "minus" button stays broken no matter what Unicode I plug in.
Comment 1 Jonathan Druart 2023-07-05 12:48:32 UTC
Created attachment 153055 [details] [review]
Bug 34129: Fix plus and minus icon
Comment 2 Jonathan Druart 2023-07-05 12:51:25 UTC
Is this... bad?
Comment 3 Jonathan Druart 2023-07-05 12:54:29 UTC
Created attachment 153056 [details] [review]
[ALTERNATE] Bug 34129: Fix plus and minus icon
Comment 4 Jonathan Druart 2023-07-05 12:54:59 UTC
(In reply to Jonathan Druart from comment #3)
> Created attachment 153056 [details] [review] [review]
> [ALTERNATE] Bug 34129: Fix plus and minus icon

This seems to work for me.
Comment 5 Owen Leonard 2023-07-05 15:30:12 UTC
(In reply to Jonathan Druart from comment #4)
> This seems to work for me.

Sorry it's not working for me. The icons are still blank even after regenerating the CSS.
Comment 6 Jonathan Druart 2023-07-05 15:45:50 UTC
Created attachment 153063 [details] [review]
Bug 34129: Fix plus and minus icon
Comment 7 Jonathan Druart 2023-07-05 15:46:09 UTC
(In reply to Owen Leonard from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > This seems to work for me.
> 
> Sorry it's not working for me. The icons are still blank even after
> regenerating the CSS.

I didn't commit the latest change, sorry!
Comment 8 Caroline Cyr La Rose 2023-08-17 08:23:55 UTC
Created attachment 154497 [details] [review]
Bug 34129: Fix plus and minus icon

This patch fixes the plus and minus on the buttons to expand the columns
in mobile or zoomed in view.

To test:
1. Apply the patch
2. Rebuild css (yarn build)
3. Go to the OPAC and search for a record with an item
4. Zoom in to 400% or change view to mobile
--> The items table should have a plus (+) button in the last column to
expand and have the rest of the information

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 9 Caroline Cyr La Rose 2023-08-17 08:25:04 UTC
It wasn't at need signoff, but I tried and it works well.

Also added a test plan.

Thanks Jonathan!
Comment 10 Owen Leonard 2023-08-18 07:24:51 UTC
*** Bug 34485 has been marked as a duplicate of this bug. ***
Comment 11 Katrin Fischer 2023-08-25 11:58:30 UTC
Fixing the issue nicely. Wondering: should or could we have an alt text on this button?
Comment 12 Katrin Fischer 2023-08-25 11:59:05 UTC
Created attachment 154804 [details] [review]
Bug 34129: Fix plus and minus icon

This patch fixes the plus and minus on the buttons to expand the columns
in mobile or zoomed in view.

To test:
1. Apply the patch
2. Rebuild css (yarn build)
3. Go to the OPAC and search for a record with an item
4. Zoom in to 400% or change view to mobile
--> The items table should have a plus (+) button in the last column to
expand and have the rest of the information

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Tomás Cohen Arazi 2023-08-29 17:36:16 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 14 Fridolin Somers 2023-08-30 06:45:08 UTC
Depends on Bug 32910 not in 23.05.x