Bug 34300

Summary: Add link to place a hold on ordered items in baskets
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: CirculationAssignee: Wainui Witika-Park <wainuiwitikapark>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: amitddng135, fridolin.somers, gmcharlt, kyle.m.hall, lisette, m.de.rooy, michaela.sieber, philip.orr, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Trivial patch
Documentation contact: Philip Orr Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/805
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Attachments: Bug 34300: Add holds column to order table
Bug 34300: Add holds column to order table
Bug 34300: Add holds column to order table
Bug 34300: (QA follow-up) Add permission check and fix missing table cells
Bug 34300: (QA follow-up) Add permission check and fix missing table cells

Description Aleisha Amohia 2023-07-18 00:46:39 UTC
Libraries would like the ability to easily place a hold on an ordered item from the basket.

We envision this button being available next to orders, by the other action buttons i.e. next to Modify/transfer and Cancel. It would be in its own column "Place hold" and should be configurable to show or hide using the Table settings.
Comment 1 Wainui Witika-Park 2023-07-18 03:25:52 UTC Comment hidden (obsolete)
Comment 2 ByWater Sandboxes 2023-07-18 19:49:30 UTC Comment hidden (obsolete)
Comment 3 Lisette Scheer 2023-07-18 19:50:05 UTC
Worked as expected, I know lots of people will be excited to see this. 
Lisette
Comment 4 Wainui Witika-Park 2023-07-18 22:27:18 UTC
(In reply to Lisette Scheer from comment #3)
> Worked as expected, I know lots of people will be excited to see this. 
> Lisette

Thanks Lisette! That's great to hear :)
Comment 5 Marcel de Rooy 2023-09-29 09:00:00 UTC
Created attachment 156367 [details] [review]
Bug 34300: Add holds column to order table

Adds the ability to easily place a hold on an ordered item from a basket

To test:
    1) Apply patch
    2) Go to acquisitions
    3) Go to an existing basket, or create a new one
    4) Add an order to the basket
    4) Notice there is a "Place hold" column in the Orders table
    5) Click the link for an item which allows you to place a hold easily on the biblio
    6) On the columns settings, toggle the "Place hold" column to hide it, and make sure it gets hidden

    Sponsored-by: Pymble Ladies’ College

Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2023-09-29 09:03:47 UTC
Passing QA with a few minor comments:

Place a hold on the order is a bit weird wording imho. Could be improved? No blocker.

I wonder if Place hold should be hidden by default. If you want it, you will enable it? No blocker.

The list of column settings (in Configure) is not ordered. This is outside scope here. But we might wanna think about that..
Comment 7 Tomás Cohen Arazi (tcohen) 2023-10-04 20:44:00 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-10-06 00:46:31 UTC
This needs a check for permission 'CAN_user_reserveforothers_place_holds' right ?
Comment 9 Katrin Fischer 2023-10-09 21:47:13 UTC
Created attachment 156771 [details] [review]
Bug 34300: (QA follow-up) Add permission check and fix missing table cells

* Changes text from "Place a hold on order" to the more common "Place hold"
* Adds permission check on reserveforothers.
* We were missing table cells in the footer rows of the table.

I would have liked to hide the column for someone missing permissions,
but I failed to get the datatable configuration right with the export
and column configuration settings.
Comment 10 Tomás Cohen Arazi (tcohen) 2023-10-10 11:25:15 UTC
Can I get a review on the follow-up?
Comment 11 Katrin Fischer 2023-10-10 11:57:27 UTC
*** Bug 10498 has been marked as a duplicate of this bug. ***
Comment 12 Nick Clemens (kidclamp) 2023-10-12 15:34:17 UTC
Created attachment 156983 [details] [review]
Bug 34300: (QA follow-up) Add permission check and fix missing table cells

* Changes text from "Place a hold on order" to the more common "Place hold"
* Adds permission check on reserveforothers.
* We were missing table cells in the footer rows of the table.

I would have liked to hide the column for someone missing permissions,
but I failed to get the datatable configuration right with the export
and column configuration settings.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 13 Katrin Fischer 2023-10-13 18:00:02 UTC
Thx Nick!
Comment 14 Tomás Cohen Arazi (tcohen) 2023-10-20 12:24:59 UTC
Follow-up pushed to master. Thanks!