Summary: | Catalog by itemtype report pulling from holdingbranch | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Reports | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed fix
Fix for Bug 3431 - Catalog by itemtype report pulling from holdingbranch |
Description
Chris Cormack
2010-05-21 01:10:25 UTC
Created attachment 5110 [details] [review] Proposed fix Several fixes for this report no one uses: - Clarifying titles and breadcrumbs - Correcting terminology: branch -> library - Sorting library select field by library name - Displaying library name instead of code on output - Sorting results by itemtype description - Adding tablesorter to results Oh, and here's why I clarified the description instead of changing the query to pull homebranch. I see this as a report of items *held* at your library, not owned. But it's okay, no one uses this report anyway. I agree this report is not used, but the changes made make it more useful to never use. Will sign off Created attachment 6715 [details] [review] Fix for Bug 3431 - Catalog by itemtype report pulling from holdingbranch Plus several other fixes for this report no one uses: - Clarifying titles and breadcrumbs - Correcting terminology: branch -> library - Sorting library select field by library name - Displaying library name instead of code on output - Sorting results by itemtype description - Adding tablesorter to results Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA comment: clean code, passes perlcritic, clarify report passed QA patch pushed, please test |