| Summary: | Hold reordering arrows look broken after Font Awesome upgrade | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | emily.lamancusa, fridolin.somers, gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 32910 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade
Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade |
||
|
Description
Owen Leonard
2023-07-20 10:53:48 UTC
Created attachment 153715 [details] [review] Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade This patch makes minor CSS corrections to the arrows on the place hold page in the staff interface. The corrections are necessary because of changes in the display of icons in Font Awesome 6. To test, apply the patch and locate a bibliographic record in the staff interface to place a hold on. - Place at least one hold on that title. - After placing the hold, you should see a table of all the existing holds on that record. - The arrow control links should look correct, with the "move to top" and "move to bottom" arrows having an extra border to differentiate them from the others. Created attachment 153734 [details] [review] Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade This patch makes minor CSS corrections to the arrows on the place hold page in the staff interface. The corrections are necessary because of changes in the display of icons in Font Awesome 6. To test, apply the patch and locate a bibliographic record in the staff interface to place a hold on. - Place at least one hold on that title. - After placing the hold, you should see a table of all the existing holds on that record. - The arrow control links should look correct, with the "move to top" and "move to bottom" arrows having an extra border to differentiate them from the others. Signed-off-by: Sam Lau <samalau@gmail.com> Trivial patch, looks good and QA tool is happy. Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x (In reply to Fridolin Somers from comment #5) > Enhancement not pushed to 23.05.x I mean : Depends on Bug 32910 not in 23.05.x |