Bug 34344

Summary:	Make item types breadcrumbs uniform
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	enhancement
Priority:	P5 - low	CC:	fridolin.somers
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Attachments:	Bug 34344: Make item types breadcrumbs uniform Bug 34344: Make item types breadcrumbs uniform Bug 34344: Make item types breadcrumbs uniform

Description Caroline Cyr La Rose 2023-07-21 19:42:06 UTC

I noticed while testing bug 33909 that the breadcrumbs for the item types administration page are not like the other administration pages.

For example, the breadcrumbs in the libraries page are
Home > Administration > Libraries

The breadcrumbs in the patron categories page are
Home > Administration > Patron categories

Whereas the breadcrumbs in the item types page are
Home > Administration > Item types administration

I think we should remove the second "administration".

Comment 1 Owen Leonard 2023-07-24 11:06:58 UTC

Created attachment 153834 [details] [review]
Bug 34344: Make item types breadcrumbs uniform

This patch updates the breadcrumbs on the item types administration page
so that it reads "Item types" instead of "Item types administration,"
making it more consistent with other administration pages. The same
change is made to the page's main heading.

To test, apply the patch and go to Administration -> Item types.

The breadcrumbs should read "Home -> Administration -> Item types. The
page heading should read "Item types."

Comment 2 Caroline Cyr La Rose 2023-07-26 17:03:47 UTC

Created attachment 153932 [details] [review]
Bug 34344: Make item types breadcrumbs uniform

This patch updates the breadcrumbs on the item types administration page
so that it reads "Item types" instead of "Item types administration,"
making it more consistent with other administration pages. The same
change is made to the page's main heading.

To test, apply the patch and go to Administration -> Item types.

The breadcrumbs should read "Home -> Administration -> Item types. The
page heading should read "Item types."

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Comment 3 Katrin Fischer 2023-07-31 20:19:10 UTC

Created attachment 154114 [details] [review]
Bug 34344: Make item types breadcrumbs uniform

This patch updates the breadcrumbs on the item types administration page
so that it reads "Item types" instead of "Item types administration,"
making it more consistent with other administration pages. The same
change is made to the page's main heading.

To test, apply the patch and go to Administration -> Item types.

The breadcrumbs should read "Home -> Administration -> Item types. The
page heading should read "Item types."

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-08-15 09:14:10 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-08-17 20:12:03 UTC

Enhancement not pushed to 23.05.x