While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Item types page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Add item type' in page title to 'New item type' - Change "Delete item type 'Y'?" to "Confirm deletion of item type 'Y'" in page title Breadcrumb - Change 'Item types administration' in breadcrumb to 'Item types' - Change 'Add item type' in breadcrumb to 'New item type' - Change "Delete item type 'Y'?" to "Confirm deletion of item type 'Y'" in breadcrumb Page header - Change 'Item types administration' in page header to 'Item types' - Change 'Add item type' in page header to 'New item type' - Add item type code to Modify X in page header - Change "Delete item type 'Y'?" to "Are you sure you want to delete item type 'Y'" in page header
> Breadcrumb > - Change 'Item types administration' in breadcrumb to 'Item types' > > Page header > - Change 'Item types administration' in page header to 'Item types' These two points are corrected in bug 34344.
Created attachment 155229 [details] [review] Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header This patch fixes inconsistencies in the item type administration page so that page titles, breadcrumb navigation, and page headers are consistent with each other and with other pages in Koha. To test, apply the patch and go to Administration -> Item types. Check each variation of the page to confirm that everything looks correct: - Item types list - New item type - Edit item type - Confirm deletion of item type
I think this patch creates an inconsistency on http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form where the title and breadcrumbs are saying "New item type" but the <h1> header is still saying "Add item type". -- I also noticed when I tried to delete the item type "Books" that it just says: "Cannot delete this item type. This record is in use. Deletion is not possible." That differs from the deletion message you see when you try to delete "Computer Files", which asks "Are you sure you want to delete item type 'CF'?" which is one of the updated deletion messages.
Created attachment 155405 [details] [review] Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header This patch fixes inconsistencies in the item type administration page so that page titles, breadcrumb navigation, and page headers are consistent with each other and with other pages in Koha. To test, apply the patch and go to Administration -> Item types. Check each variation of the page to confirm that everything looks correct: - Item types list - New item type - Edit item type - Confirm deletion of item type
(In reply to David Cook from comment #3) > "Cannot delete this item type. > This record is in use. Deletion is not possible." This message is displayed when the item type is in use. > That differs from the deletion message you see when you try to delete > "Computer Files", which asks "Are you sure you want to delete item type > 'CF'?" This message is different because it's asking for confirmation before deleting an item type which is not in use. I think the differences in these messages is to be expected.
Created attachment 155496 [details] [review] Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header This patch fixes inconsistencies in the item type administration page so that page titles, breadcrumb navigation, and page headers are consistent with each other and with other pages in Koha. To test, apply the patch and go to Administration -> Item types. Check each variation of the page to confirm that everything looks correct: - Item types list - New item type - Edit item type - Confirm deletion of item type Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Created attachment 155742 [details] [review] Bug 34380: Fix inconsistencies in Item types page titles, breadcrumbs, and header This patch fixes inconsistencies in the item type administration page so that page titles, breadcrumb navigation, and page headers are consistent with each other and with other pages in Koha. To test, apply the patch and go to Administration -> Item types. Check each variation of the page to confirm that everything looks correct: - Item types list - New item type - Edit item type - Confirm deletion of item type Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Like others, not pushed to 23.05.x