Bug 34378

Summary:	Inconsistencies in Libraries page titles, breadcrumbs, and header
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, paul.poulain
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:	33909
Bug Blocks:	34396
Attachments:	Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header

Description Caroline Cyr La Rose 2023-07-25 16:29:03 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Libraries page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Remove library code from New X (this is only visible in the code, unless I misunderstand the line)
- Add library code to Modify X in page title (e.g. Modify library 'CPL')

Breadcrumb
- Add library code to Modify X in breadcrumb (e.g. Modify library 'CPL')

Page header
- Add library code to Modify X in page header (e.g. Modify library 'CPL')

Comment 1 Owen Leonard 2023-08-18 08:48:37 UTC

Created attachment 154606 [details] [review]
Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header

This patch makes changes to the libraries administration page so that
the page title, breadcrumbs, and page headings are more consistent with
each other.

To test, apply the patch and go to Administration -> Libraries.

- Click "New library"
- The page title, breadcrumb navigation, and page heading should all
  read "New library"
- Enter some details, save your new library, and then click the "Delete"
  button corresponding to your new library.
- On the deletion conformation page, the page title and breadcrumb
  navigation should match, "Confirm deletion of library 'X'"
- Edit a library. On the edit page, the page title, breadcrumb
  navigation, and page heading should match: "Modify library 'X'"

Comment 2 Biblibre Sandboxes 2023-08-18 09:04:59 UTC

Created attachment 154609 [details] [review]
Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header

This patch makes changes to the libraries administration page so that
the page title, breadcrumbs, and page headings are more consistent with
each other.

To test, apply the patch and go to Administration -> Libraries.

- Click "New library"
- The page title, breadcrumb navigation, and page heading should all
  read "New library"
- Enter some details, save your new library, and then click the "Delete"
  button corresponding to your new library.
- On the deletion conformation page, the page title and breadcrumb
  navigation should match, "Confirm deletion of library 'X'"
- Edit a library. On the edit page, the page title, breadcrumb
  navigation, and page heading should match: "Modify library 'X'"

Signed-off-by: paul <paul.poulain@biblibre.com>

Comment 3 Katrin Fischer 2023-08-24 21:24:30 UTC

Created attachment 154757 [details] [review]
Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header

This patch makes changes to the libraries administration page so that
the page title, breadcrumbs, and page headings are more consistent with
each other.

To test, apply the patch and go to Administration -> Libraries.

- Click "New library"
- The page title, breadcrumb navigation, and page heading should all
  read "New library"
- Enter some details, save your new library, and then click the "Delete"
  button corresponding to your new library.
- On the deletion conformation page, the page title and breadcrumb
  navigation should match, "Confirm deletion of library 'X'"
- Edit a library. On the edit page, the page title, breadcrumb
  navigation, and page heading should match: "Modify library 'X'"

Signed-off-by: paul <paul.poulain@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-08-29 17:58:18 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-08-30 06:59:46 UTC

Depends on Bug 33909 not in 23.05.x