Bug 34381

Summary:	Inconsistencies in Authorized values page title
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	christian.nelson, fridolin.somers
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:	33909
Bug Blocks:	34396
Attachments:	Bug 34381: Correct inconsistencies in Authorized values page title Bug 34381: Correct inconsistencies in Authorized values page title Bug 34381: Correct inconsistencies in Authorized values page title

Description Caroline Cyr La Rose 2023-07-25 16:35:27 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Authorized values page, here is what should be changed to make it consistent with the other pages in the module:

- Add a level in the page title when viewing authorized values of a category (e.g. Authorized values for category 'Y' > Authorized values > Administration > Koha) (note: this level is already present for 'New authorized value' or 'Modify authorized value')

I wonder if we should add a page to confirm the deletion of an authorized value or authorized value category? Right now, it's only a browser prompt, whereas other sections have their own deletion confirmation page.

Comment 1 Owen Leonard 2023-08-18 09:34:43 UTC

Created attachment 154627 [details] [review]
Bug 34381: Correct inconsistencies in Authorized values page title

This patch rewords the authorized values template title logic so that it
matches the breadcrumb navigation for consistency.

To test, apply the patch and go to Administration -> Authorized values.

Test all versions of the page to confirm that the breadcrumbs and page
title are consistent with each other:

 - Main view
 - New category
 - View category (click a category, e.g. CCODE, in the main view)
 - Add authorized value
 - Edit authorized value

Comment 2 PTFS Europe Sandboxes 2023-08-18 10:48:07 UTC

Created attachment 154635 [details] [review]
Bug 34381: Correct inconsistencies in Authorized values page title

This patch rewords the authorized values template title logic so that it
matches the breadcrumb navigation for consistency.

To test, apply the patch and go to Administration -> Authorized values.

Test all versions of the page to confirm that the breadcrumbs and page
title are consistent with each other:

 - Main view
 - New category
 - View category (click a category, e.g. CCODE, in the main view)
 - Add authorized value
 - Edit authorized value

Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi>

Comment 3 Christian Nelson 2023-08-18 10:48:43 UTC

Seems to work fine.

Comment 4 Katrin Fischer 2023-08-24 21:31:02 UTC

Created attachment 154759 [details] [review]
Bug 34381: Correct inconsistencies in Authorized values page title

This patch rewords the authorized values template title logic so that it
matches the breadcrumb navigation for consistency.

To test, apply the patch and go to Administration -> Authorized values.

Test all versions of the page to confirm that the breadcrumbs and page
title are consistent with each other:

 - Main view
 - New category
 - View category (click a category, e.g. CCODE, in the main view)
 - Add authorized value
 - Edit authorized value

Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Tomás Cohen Arazi (tcohen) 2023-08-29 17:58:25 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 6 Fridolin Somers 2023-08-30 07:01:52 UTC

Does not apply on 23.05.x, maybe depends on Bug 33909 ?