While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Authorized values page, here is what should be changed to make it consistent with the other pages in the module: - Add a level in the page title when viewing authorized values of a category (e.g. Authorized values for category 'Y' > Authorized values > Administration > Koha) (note: this level is already present for 'New authorized value' or 'Modify authorized value') I wonder if we should add a page to confirm the deletion of an authorized value or authorized value category? Right now, it's only a browser prompt, whereas other sections have their own deletion confirmation page.
Created attachment 154627 [details] [review] Bug 34381: Correct inconsistencies in Authorized values page title This patch rewords the authorized values template title logic so that it matches the breadcrumb navigation for consistency. To test, apply the patch and go to Administration -> Authorized values. Test all versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New category - View category (click a category, e.g. CCODE, in the main view) - Add authorized value - Edit authorized value
Created attachment 154635 [details] [review] Bug 34381: Correct inconsistencies in Authorized values page title This patch rewords the authorized values template title logic so that it matches the breadcrumb navigation for consistency. To test, apply the patch and go to Administration -> Authorized values. Test all versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New category - View category (click a category, e.g. CCODE, in the main view) - Add authorized value - Edit authorized value Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi>
Seems to work fine.
Created attachment 154759 [details] [review] Bug 34381: Correct inconsistencies in Authorized values page title This patch rewords the authorized values template title logic so that it matches the breadcrumb navigation for consistency. To test, apply the patch and go to Administration -> Authorized values. Test all versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New category - View category (click a category, e.g. CCODE, in the main view) - Add authorized value - Edit authorized value Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Does not apply on 23.05.x, maybe depends on Bug 33909 ?