Bug 34382

Summary:	Inconsistencies in Patron categories page titles, breadcrumbs, and header
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	amanda.hovey, fridolin.somers
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:	33909
Bug Blocks:	34396
Attachments:	Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header

Description Caroline Cyr La Rose 2023-07-25 16:49:18 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Patron categories page, here is what should be changed to make it consistent with the other pages in the module:

Page header
- Add single quotes around the category code in Modify page
- Add single quotes around the category code in Delete confirmation page
- In the 'Cannot delete' page, the header styling is different
- In the 'Delete confirmation' page, the header styling is different


I'm not sure what to do about the deletion impossible page... It feels inconsistent, but I can't really find other examples.

- The page title is "Cannot delete: category 'Y'"; the colon is what bugs me the most, 'Cannot' also feels informal to me

- The breadcrumb is "Cannot delete: Category Y in use"; the colon, capital C on Category, no quotes around the category code, reason for error in breadcrumb?

- The page header is "Category Y is in use. Deletion not possible!"; This is good information, but should it be the header?

Comment 1 Owen Leonard 2023-08-18 10:30:32 UTC

Created attachment 154634 [details] [review]
Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header

This patch makes some changes to the patron categories administration
page so that the page title, breadcrumb navigation, and headings are
more consistent with each other.

To test, apply the patch and go to Administration -> Patron categories.

- Test all variations of the page:
  - Main page (listing categories)
  - New category
  - Edit category
  - Confirm deletion of category when the category is in use (there are
    existing patrons who have that category)
  - Confirm deletion of category when the category is not in use

Note: This patch contains whitespace changes, so please ignore
whitespace if you're checking the diff.

Comment 2 PTFS Europe Sandboxes 2023-08-18 11:08:55 UTC

Created attachment 154637 [details] [review]
Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header

This patch makes some changes to the patron categories administration
page so that the page title, breadcrumb navigation, and headings are
more consistent with each other.

To test, apply the patch and go to Administration -> Patron categories.

- Test all variations of the page:
  - Main page (listing categories)
  - New category
  - Edit category
  - Confirm deletion of category when the category is in use (there are
    existing patrons who have that category)
  - Confirm deletion of category when the category is not in use

Note: This patch contains whitespace changes, so please ignore
whitespace if you're checking the diff.

Signed-off-by: Amanda Hovey <amanda.hovey@parliament.nsw.gov.au>

Comment 3 Amanda Hovey 2023-08-18 11:10:18 UTC

Signed off by AH, JM, CN at KohaCon 2023

Comment 4 Katrin Fischer 2023-08-24 21:38:12 UTC

Created attachment 154760 [details] [review]
Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header

This patch makes some changes to the patron categories administration
page so that the page title, breadcrumb navigation, and headings are
more consistent with each other.

To test, apply the patch and go to Administration -> Patron categories.

- Test all variations of the page:
  - Main page (listing categories)
  - New category
  - Edit category
  - Confirm deletion of category when the category is in use (there are
    existing patrons who have that category)
  - Confirm deletion of category when the category is not in use

Note: This patch contains whitespace changes, so please ignore
whitespace if you're checking the diff.

Signed-off-by: Amanda Hovey <amanda.hovey@parliament.nsw.gov.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Tomás Cohen Arazi (tcohen) 2023-08-29 17:58:29 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 6 Fridolin Somers 2023-08-30 07:02:41 UTC

Does not apply on 23.05.x, maybe depends on Bug 33909 ?