While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Patron categories page, here is what should be changed to make it consistent with the other pages in the module: Page header - Add single quotes around the category code in Modify page - Add single quotes around the category code in Delete confirmation page - In the 'Cannot delete' page, the header styling is different - In the 'Delete confirmation' page, the header styling is different I'm not sure what to do about the deletion impossible page... It feels inconsistent, but I can't really find other examples. - The page title is "Cannot delete: category 'Y'"; the colon is what bugs me the most, 'Cannot' also feels informal to me - The breadcrumb is "Cannot delete: Category Y in use"; the colon, capital C on Category, no quotes around the category code, reason for error in breadcrumb? - The page header is "Category Y is in use. Deletion not possible!"; This is good information, but should it be the header?
Created attachment 154634 [details] [review] Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header This patch makes some changes to the patron categories administration page so that the page title, breadcrumb navigation, and headings are more consistent with each other. To test, apply the patch and go to Administration -> Patron categories. - Test all variations of the page: - Main page (listing categories) - New category - Edit category - Confirm deletion of category when the category is in use (there are existing patrons who have that category) - Confirm deletion of category when the category is not in use Note: This patch contains whitespace changes, so please ignore whitespace if you're checking the diff.
Created attachment 154637 [details] [review] Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header This patch makes some changes to the patron categories administration page so that the page title, breadcrumb navigation, and headings are more consistent with each other. To test, apply the patch and go to Administration -> Patron categories. - Test all variations of the page: - Main page (listing categories) - New category - Edit category - Confirm deletion of category when the category is in use (there are existing patrons who have that category) - Confirm deletion of category when the category is not in use Note: This patch contains whitespace changes, so please ignore whitespace if you're checking the diff. Signed-off-by: Amanda Hovey <amanda.hovey@parliament.nsw.gov.au>
Signed off by AH, JM, CN at KohaCon 2023
Created attachment 154760 [details] [review] Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header This patch makes some changes to the patron categories administration page so that the page title, breadcrumb navigation, and headings are more consistent with each other. To test, apply the patch and go to Administration -> Patron categories. - Test all variations of the page: - Main page (listing categories) - New category - Edit category - Confirm deletion of category when the category is in use (there are existing patrons who have that category) - Confirm deletion of category when the category is not in use Note: This patch contains whitespace changes, so please ignore whitespace if you're checking the diff. Signed-off-by: Amanda Hovey <amanda.hovey@parliament.nsw.gov.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Does not apply on 23.05.x, maybe depends on Bug 33909 ?