Bug 34383

Summary:	Inconsistencies in Patron attributes page titles, breadcrumbs, and header
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	enhancement
Priority:	P5 - low	CC:	christian.nelson, fridolin.somers
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	34396
Attachments:	Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header

Description Caroline Cyr La Rose 2023-07-25 16:53:01 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Patron attributes page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'Add patron attribute type' to 'New patron attribute type'
- Add patron attribute type code, in single quotes, in the Modify page

Breadcrumb
- Change 'Add patron attribute type' to 'New patron attribute type'
- Add patron attribute type code, in single quotes, in the Modify page

Page header
- Change 'Add patron attribute type' to 'New patron attribute type'
- Add patron attribute type code, in single quotes, in the Modify page

Comment 1 Owen Leonard 2023-08-18 10:58:58 UTC

Created attachment 154636 [details] [review]
Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header

This patch makes changes to the patron attribute types administration
template so that the page title, breadcrumb navigation, and page headers
are more consistent with each other and with other parts of Koha.

To test, apply the patch and go to Administration -> Patron attribute
types. Test these versions of the page to confirm that the breadcrumbs
and page title are consistent with each other:

- Main view
- New patron attribute type
- Edit patron attribute type
- Confirm deletion of attribute type

Comment 2 PTFS Europe Sandboxes 2023-08-18 12:21:08 UTC

Created attachment 154652 [details] [review]
Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header

This patch makes changes to the patron attribute types administration
template so that the page title, breadcrumb navigation, and page headers
are more consistent with each other and with other parts of Koha.

To test, apply the patch and go to Administration -> Patron attribute
types. Test these versions of the page to confirm that the breadcrumbs
and page title are consistent with each other:

- Main view
- New patron attribute type
- Edit patron attribute type
- Confirm deletion of attribute type

Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi>

Comment 3 Christian Nelson 2023-08-18 12:22:50 UTC

Confirmed that breadcrumbs and page title are consistent with the patch.

Comment 4 Katrin Fischer 2023-09-21 20:51:43 UTC

Created attachment 156011 [details] [review]
Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header

This patch makes changes to the patron attribute types administration
template so that the page title, breadcrumb navigation, and page headers
are more consistent with each other and with other parts of Koha.

To test, apply the patch and go to Administration -> Patron attribute
types. Test these versions of the page to confirm that the breadcrumbs
and page title are consistent with each other:

- Main view
- New patron attribute type
- Edit patron attribute type
- Confirm deletion of attribute type

Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Tomás Cohen Arazi (tcohen) 2023-09-22 14:34:59 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 6 Fridolin Somers 2023-09-22 19:52:23 UTC

Enhancement not pushed to 23.05.x