While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Patron attributes page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Add patron attribute type' to 'New patron attribute type' - Add patron attribute type code, in single quotes, in the Modify page Breadcrumb - Change 'Add patron attribute type' to 'New patron attribute type' - Add patron attribute type code, in single quotes, in the Modify page Page header - Change 'Add patron attribute type' to 'New patron attribute type' - Add patron attribute type code, in single quotes, in the Modify page
Created attachment 154636 [details] [review] Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header This patch makes changes to the patron attribute types administration template so that the page title, breadcrumb navigation, and page headers are more consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Patron attribute types. Test these versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New patron attribute type - Edit patron attribute type - Confirm deletion of attribute type
Created attachment 154652 [details] [review] Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header This patch makes changes to the patron attribute types administration template so that the page title, breadcrumb navigation, and page headers are more consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Patron attribute types. Test these versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New patron attribute type - Edit patron attribute type - Confirm deletion of attribute type Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi>
Confirmed that breadcrumbs and page title are consistent with the patch.
Created attachment 156011 [details] [review] Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header This patch makes changes to the patron attribute types administration template so that the page title, breadcrumb navigation, and page headers are more consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Patron attribute types. Test these versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New patron attribute type - Edit patron attribute type - Confirm deletion of attribute type Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x