Bug 34389

Summary:	Inconsistencies in Debit types page titles, breadcrumbs, and header
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	david, fridolin.somers
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This fixes a couple of inconsistencies in the debit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other.	Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	34396
Attachments:	Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header

Description Caroline Cyr La Rose 2023-07-25 18:16:09 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Debit types page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Add debit type code to Modify X (e.g. Modify debit type 'MANUAL')

Breadcrumb
- Add debit type code to Modify X (e.g. Modify debit type 'MANUAL')

Page header
- Change 'Modify a debit type' to "Modify debit type 'Y'"

Comment 1 Owen Leonard 2023-10-02 15:50:24 UTC

Created attachment 156457 [details] [review]
Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the debit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Debit types. Test
each variation of the page:

- Main page
- New debit type
- Modify debit type

Comment 2 David Nind 2023-10-02 23:39:53 UTC

Created attachment 156465 [details] [review]
Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the debit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Debit types. Test
each variation of the page:

- Main page
- New debit type
- Modify debit type

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2023-10-03 09:58:07 UTC

Created attachment 156484 [details] [review]
Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the debit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Debit types. Test
each variation of the page:

- Main page
- New debit type
- Modify debit type

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-10-03 13:18:49 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-10-05 19:27:28 UTC

Not pushed to 23.05.x