Bug 34397

Summary:	Inconsistencies in Classification sources page titles, breadcrumbs, and header
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	34396
Attachments:	Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers

Description Caroline Cyr La Rose 2023-07-25 19:40:48 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Classification sources page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'Classification sources' to 'Classification configuration' (should we change to simply 'Classification'? No other section has 'configuration')
- Change 'Add classification source' to 'New classification source'
- Add classification source code in single quotes to 'Modify classification source'
- Change 'Add filing rule' to 'New filing rule'
- Add filing rule code in single quotes to 'Modify filing rule'
- Change 'Add splitting rule' to 'New splitting rule'
- Add splitting rule code in single quotes to 'Modify splitting rule'

Breadcrumb
- Change 'Add classification source' to 'New classification source'
- Add classification source code in single quotes to 'Modify classification source'
- Change 'Add filing rule' to 'New filing rule'
- Add filing rule code in single quotes to 'Modify filing rule'
- Change 'Add splitting rule' to 'New splitting rule'
- Add splitting rule code in single quotes to 'Modify splitting rule'


Page header
- Change 'Add classification source' to 'New classification source'
- Add classification source code in single quotes to 'Modify classification source'
- Change 'Add filing rule' to 'New filing rule'
- Add filing rule code in single quotes to 'Modify filing rule'
- Change 'Add splitting rule' to 'New splitting rule'
- Add splitting rule code in single quotes to 'Modify splitting rule'


There is no special page for deletion confirmation, simply a browser prompt.

Comment 1 Owen Leonard 2023-10-03 16:30:00 UTC

Created attachment 156508 [details] [review]
Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the classification
configuration administration page, making sure the page title,
breadcrumb navigation, and page headers are consistent with each other.

Test each view to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Classification configuration
  - New classification source
  - Edit classification source
  - New filing rule
  - Edit filing rule
  - New splitting rule
  - Edit splitting rule

Comment 2 David Nind 2023-10-28 23:36:56 UTC

Created attachment 158020 [details] [review]
Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the classification
configuration administration page, making sure the page title,
breadcrumb navigation, and page headers are consistent with each other.

Test each view to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Classification configuration
  - New classification source
  - Edit classification source
  - New filing rule
  - Edit filing rule
  - New splitting rule
  - Edit splitting rule

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2023-11-04 17:45:51 UTC

Created attachment 158390 [details] [review]
Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the classification
configuration administration page, making sure the page title,
breadcrumb navigation, and page headers are consistent with each other.

Test each view to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Classification configuration
  - New classification source
  - Edit classification source
  - New filing rule
  - Edit filing rule
  - New splitting rule
  - Edit splitting rule

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-11-06 11:39:26 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-11-10 07:06:25 UTC

Not pushed to 23.05.x