While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Classification sources page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Classification sources' to 'Classification configuration' (should we change to simply 'Classification'? No other section has 'configuration') - Change 'Add classification source' to 'New classification source' - Add classification source code in single quotes to 'Modify classification source' - Change 'Add filing rule' to 'New filing rule' - Add filing rule code in single quotes to 'Modify filing rule' - Change 'Add splitting rule' to 'New splitting rule' - Add splitting rule code in single quotes to 'Modify splitting rule' Breadcrumb - Change 'Add classification source' to 'New classification source' - Add classification source code in single quotes to 'Modify classification source' - Change 'Add filing rule' to 'New filing rule' - Add filing rule code in single quotes to 'Modify filing rule' - Change 'Add splitting rule' to 'New splitting rule' - Add splitting rule code in single quotes to 'Modify splitting rule' Page header - Change 'Add classification source' to 'New classification source' - Add classification source code in single quotes to 'Modify classification source' - Change 'Add filing rule' to 'New filing rule' - Add filing rule code in single quotes to 'Modify filing rule' - Change 'Add splitting rule' to 'New splitting rule' - Add splitting rule code in single quotes to 'Modify splitting rule' There is no special page for deletion confirmation, simply a browser prompt.
Created attachment 156508 [details] [review] Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the classification configuration administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Test each view to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Classification configuration - New classification source - Edit classification source - New filing rule - Edit filing rule - New splitting rule - Edit splitting rule
Created attachment 158020 [details] [review] Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the classification configuration administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Test each view to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Classification configuration - New classification source - Edit classification source - New filing rule - Edit filing rule - New splitting rule - Edit splitting rule Signed-off-by: David Nind <david@davidnind.com>
Created attachment 158390 [details] [review] Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the classification configuration administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Test each view to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Classification configuration - New classification source - Edit classification source - New filing rule - Edit filing rule - New splitting rule - Edit splitting rule Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Not pushed to 23.05.x