Summary: | Inconsistencies in OAI sets page titles, breadcrumbs, and header | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dcook, fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 34396 | ||
Attachments: |
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header
Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header |
Description
Caroline Cyr La Rose
2023-07-25 19:54:17 UTC
Created attachment 155035 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings Comment on attachment 155035 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header Review of attachment 155035 [details] [review]: ----------------------------------------------------------------- Overall, I think it's looking pretty good, but I did note a new inconsistency introduced by this patch. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt @@ +29,4 @@ > > [% IF ( op_new || op_mod ) %] > [% WRAPPER breadcrumb_item %] > + <a href="/cgi-bin/koha/admin/oai_sets.pl">OAI sets</a> This change makes the breadcrumb inconsistent with oai_set_mappings.tt though. @@ +44,5 @@ > [% END %] > > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] > + <span>OAI sets</span> This change makes the breadcrumb inconsistent with oai_set_mappings.tt though. Created attachment 155261 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings Created attachment 155495 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Created attachment 155755 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Like others, not pushed to 23.05.x |