While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the OAI sets page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'OAI sets configuration' to 'OAI sets' - Change 'Add a new OAI set' to 'New OAI set' - Add a level for when modifying an existing set "Modify OAI set 'code'" - Change 'OAI set mappings' to "Mappings for set 'name' (code)" Breadcrumb - Change 'OAI sets configuration' to 'OAI sets' - Change 'Add a new OAI set' to 'New OAI set' - Change "Edit OAI set 'code'" to "Modify OAI set 'code'" - Change 'OAI set mappings' to "Mappings for set 'name' (code)" Page header - Change 'Add a new OAI set' to 'New OAI set' - Change "Edit OAI set 'code'" to "Modify OAI set 'code'
Created attachment 155035 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings
Comment on attachment 155035 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header Review of attachment 155035 [details] [review]: ----------------------------------------------------------------- Overall, I think it's looking pretty good, but I did note a new inconsistency introduced by this patch. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt @@ +29,4 @@ > > [% IF ( op_new || op_mod ) %] > [% WRAPPER breadcrumb_item %] > + <a href="/cgi-bin/koha/admin/oai_sets.pl">OAI sets</a> This change makes the breadcrumb inconsistent with oai_set_mappings.tt though. @@ +44,5 @@ > [% END %] > > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] > + <span>OAI sets</span> This change makes the breadcrumb inconsistent with oai_set_mappings.tt though.
Created attachment 155261 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings
Created attachment 155495 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Created attachment 155755 [details] [review] Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Like others, not pushed to 23.05.x