Summary: | Inconsistencies in Budgets and funds page titles, breadcrumbs, and header | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize |
Version: | Main | Keywords: | Sandbox |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 34396, 36885 | ||
Attachments: |
Bug 34404: Fix inconsistencies in Budgets and funds page titles, breadcrumbs, and headers
Bug 34404: Fix inconsistencies in Budgets and funds page titles, breadcrumbs, and headers Bug 34404: Fix inconsistencies in Budgets and funds page titles, breadcrumbs, and headers |
Description
Caroline Cyr La Rose
2023-07-25 20:40:30 UTC
Created attachment 156573 [details] [review] Bug 34404: Fix inconsistencies in Budgets and funds page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the budget and fund administration templates, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Other changes: Bootstrap tooltips have been enabled in a few places where the markup showed intent for the tooltips to be active but where the JS was not being initiated. Some translation imrovements have been added where budget planning strings could be improved with context: '<span>by months</span>' -> '[% tp("Budget planning", "by months") | html %]' To test, apply the patch and go to Administration -> Budgets. Test each of these cases: - Budgets list - New budget - Edit budget - Duplicate budget - Close budget - Close a budget with and without unreceived orders. - Delete budget - Test the delete button on a budget which has funds attached to confirm that the menu item is disabled and a tooltip shows with an explanation. - Delete a budget which has no funds attached. - Add fund - Test the add fund button on a budget which is locked. The menu item should be disabled and it should show a tooltip, "Budget is locked." - Test the add fund page for a budget which is not locked. - Click the name of a budget with funds attached to see the funds view - In this view, if the budget is locked, the "New" toolbar menu should have a disabled "New fund" item with a Bootstrap tooltip. - While viewing the funds on a budget, test the "Planning" button to confirm that the view of each planning type. Created attachment 158475 [details] [review] Bug 34404: Fix inconsistencies in Budgets and funds page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the budget and fund administration templates, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Other changes: Bootstrap tooltips have been enabled in a few places where the markup showed intent for the tooltips to be active but where the JS was not being initiated. Some translation imrovements have been added where budget planning strings could be improved with context: '<span>by months</span>' -> '[% tp("Budget planning", "by months") | html %]' To test, apply the patch and go to Administration -> Budgets. Test each of these cases: - Budgets list - New budget - Edit budget - Duplicate budget - Close budget - Close a budget with and without unreceived orders. - Delete budget - Test the delete button on a budget which has funds attached to confirm that the menu item is disabled and a tooltip shows with an explanation. - Delete a budget which has no funds attached. - Add fund - Test the add fund button on a budget which is locked. The menu item should be disabled and it should show a tooltip, "Budget is locked." - Test the add fund page for a budget which is not locked. - Click the name of a budget with funds attached to see the funds view - In this view, if the budget is locked, the "New" toolbar menu should have a disabled "New fund" item with a Bootstrap tooltip. - While viewing the funds on a budget, test the "Planning" button to confirm that the view of each planning type. Signed-off-by: David Nind <david@davidnind.com> Created attachment 158559 [details] [review] Bug 34404: Fix inconsistencies in Budgets and funds page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the budget and fund administration templates, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Other changes: Bootstrap tooltips have been enabled in a few places where the markup showed intent for the tooltips to be active but where the JS was not being initiated. Some translation imrovements have been added where budget planning strings could be improved with context: '<span>by months</span>' -> '[% tp("Budget planning", "by months") | html %]' To test, apply the patch and go to Administration -> Budgets. Test each of these cases: - Budgets list - New budget - Edit budget - Duplicate budget - Close budget - Close a budget with and without unreceived orders. - Delete budget - Test the delete button on a budget which has funds attached to confirm that the menu item is disabled and a tooltip shows with an explanation. - Delete a budget which has no funds attached. - Add fund - Test the add fund button on a budget which is locked. The menu item should be disabled and it should show a tooltip, "Budget is locked." - Test the add fund page for a budget which is not locked. - Click the name of a budget with funds attached to see the funds view - In this view, if the budget is locked, the "New" toolbar menu should have a disabled "New fund" item with a Bootstrap tooltip. - While viewing the funds on a budget, test the "Planning" button to confirm that the view of each planning type. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Not pushed to 23.05.x |