Bug 34409

Summary:	Inconsistencies in Audio alerts page titles, breadcrumbs, and header
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, salah.ghedda
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	34396
Attachments:	Bug 34409: Fix inconsistencies in Audio alerts headers Bug 34409: Fix inconsistencies in Audio alerts headers Bug 34409: Fix inconsistencies in Audio alerts headers Bug 34409: Fix inconsistencies in Audio alerts headers

Description Caroline Cyr La Rose 2023-07-25 21:33:47 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Audio alerts page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Add level for when adding a new audio alert 'New audio alert'
- Add level for when editing an existing audio alert "Modify audio alert 'selector'" (not sure what makes sense here, selector?)

Breadcrumb
- Add level for when adding a new audio alert 'New audio alert'
- Add level for when editing an existing audio alert "Modify audio alert 'selector'" (not sure what makes sense here, selector?)

Page header
- Change 'Add new alert' to 'New audio alert'
- The styling of the header 'Add new alert' is different than usual
- Change 'Edit alert' to "Modify audio alert 'selector'" (not sure what makes sense here, selector?)
- The styling of the header 'Edit alert' is different than usual

Comment 1 Owen Leonard 2023-09-07 16:44:29 UTC

Created attachment 155336 [details] [review]
Bug 34409: Fix inconsistencies in Audio alerts headers

This patch makes a minor change to the structure of the audio alerts
administration template so that the add/edit form is more consistent
with other similar forms.

The patch doesn't make any changes to page title and breadcrumbs because
the add/edit action doesn't trigger a page reload, so the required
change can't be made just with markup.

To test, apply the patch and enable the AudioAlerts system preference
if necessary.

- Go to Administration -> Audio alerts.
- Click "New alert" and confirm that the form looks correct.
- Edit an existing alert to confirm that this view also looks correct.

Comment 2 Salah Ghedda 2023-09-11 13:16:59 UTC

Created attachment 155485 [details] [review]
Bug 34409: Fix inconsistencies in Audio alerts headers

This patch makes a minor change to the structure of the audio alerts
administration template so that the add/edit form is more consistent
with other similar forms.

The patch doesn't make any changes to page title and breadcrumbs because
the add/edit action doesn't trigger a page reload, so the required
change can't be made just with markup.

To test, apply the patch and enable the AudioAlerts system preference
if necessary.

- Go to Administration -> Audio alerts.
- Click "New alert" and confirm that the form looks correct.
- Edit an existing alert to confirm that this view also looks correct.

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>


Signed Off

Comment 3 Salah Ghedda 2023-09-11 13:17:38 UTC

Created attachment 155486 [details] [review]
Bug 34409: Fix inconsistencies in Audio alerts headers

This patch makes a minor change to the structure of the audio alerts
administration template so that the add/edit form is more consistent
with other similar forms.

The patch doesn't make any changes to page title and breadcrumbs because
the add/edit action doesn't trigger a page reload, so the required
change can't be made just with markup.

To test, apply the patch and enable the AudioAlerts system preference
if necessary.

- Go to Administration -> Audio alerts.
- Click "New alert" and confirm that the form looks correct.
- Edit an existing alert to confirm that this view also looks correct.

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>

Comment 4 Katrin Fischer 2023-09-17 12:57:35 UTC

Created attachment 155744 [details] [review]
Bug 34409: Fix inconsistencies in Audio alerts headers

This patch makes a minor change to the structure of the audio alerts
administration template so that the add/edit form is more consistent
with other similar forms.

The patch doesn't make any changes to page title and breadcrumbs because
the add/edit action doesn't trigger a page reload, so the required
change can't be made just with markup.

To test, apply the patch and enable the AudioAlerts system preference
if necessary.

- Go to Administration -> Audio alerts.
- Click "New alert" and confirm that the form looks correct.
- Edit an existing alert to confirm that this view also looks correct.

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Tomás Cohen Arazi (tcohen) 2023-09-18 15:04:06 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 6 Fridolin Somers 2023-09-18 20:08:37 UTC

Like others, not pushed to 23.05.x