While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Audio alerts page, here is what should be changed to make it consistent with the other pages in the module: Page title - Add level for when adding a new audio alert 'New audio alert' - Add level for when editing an existing audio alert "Modify audio alert 'selector'" (not sure what makes sense here, selector?) Breadcrumb - Add level for when adding a new audio alert 'New audio alert' - Add level for when editing an existing audio alert "Modify audio alert 'selector'" (not sure what makes sense here, selector?) Page header - Change 'Add new alert' to 'New audio alert' - The styling of the header 'Add new alert' is different than usual - Change 'Edit alert' to "Modify audio alert 'selector'" (not sure what makes sense here, selector?) - The styling of the header 'Edit alert' is different than usual
Created attachment 155336 [details] [review] Bug 34409: Fix inconsistencies in Audio alerts headers This patch makes a minor change to the structure of the audio alerts administration template so that the add/edit form is more consistent with other similar forms. The patch doesn't make any changes to page title and breadcrumbs because the add/edit action doesn't trigger a page reload, so the required change can't be made just with markup. To test, apply the patch and enable the AudioAlerts system preference if necessary. - Go to Administration -> Audio alerts. - Click "New alert" and confirm that the form looks correct. - Edit an existing alert to confirm that this view also looks correct.
Created attachment 155485 [details] [review] Bug 34409: Fix inconsistencies in Audio alerts headers This patch makes a minor change to the structure of the audio alerts administration template so that the add/edit form is more consistent with other similar forms. The patch doesn't make any changes to page title and breadcrumbs because the add/edit action doesn't trigger a page reload, so the required change can't be made just with markup. To test, apply the patch and enable the AudioAlerts system preference if necessary. - Go to Administration -> Audio alerts. - Click "New alert" and confirm that the form looks correct. - Edit an existing alert to confirm that this view also looks correct. Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed Off
Created attachment 155486 [details] [review] Bug 34409: Fix inconsistencies in Audio alerts headers This patch makes a minor change to the structure of the audio alerts administration template so that the add/edit form is more consistent with other similar forms. The patch doesn't make any changes to page title and breadcrumbs because the add/edit action doesn't trigger a page reload, so the required change can't be made just with markup. To test, apply the patch and enable the AudioAlerts system preference if necessary. - Go to Administration -> Audio alerts. - Click "New alert" and confirm that the form looks correct. - Edit an existing alert to confirm that this view also looks correct. Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Created attachment 155744 [details] [review] Bug 34409: Fix inconsistencies in Audio alerts headers This patch makes a minor change to the structure of the audio alerts administration template so that the add/edit form is more consistent with other similar forms. The patch doesn't make any changes to page title and breadcrumbs because the add/edit action doesn't trigger a page reload, so the required change can't be made just with markup. To test, apply the patch and enable the AudioAlerts system preference if necessary. - Go to Administration -> Audio alerts. - Click "New alert" and confirm that the form looks correct. - Edit an existing alert to confirm that this view also looks correct. Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Like others, not pushed to 23.05.x