|
Description
Marcel de Rooy
2023-07-26 07:28:45 UTC
Created attachment 153906 [details] [review] Bug 34415: Remove T::D::C from EdiTransport.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 153907 [details] [review] Bug 34415: Move to db_dependent Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 153908 [details] [review] Bug 34415: Perltidy file Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 153909 [details] [review] Bug 34415: (follow-up) Fix count and copy file Instead of assuming a count of 0, I added an initial count. By moving the test, we need to copy the test file with quotes. Test plan: Run t/db_dependent/Koha/Edifact/Transport.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 153943 [details] [review] Bug 34415: Remove T::D::C from EdiTransport.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 153944 [details] [review] Bug 34415: Move to db_dependent Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 153945 [details] [review] Bug 34415: Perltidy file Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 153946 [details] [review] Bug 34415: (follow-up) Fix count and copy file Instead of assuming a count of 0, I added an initial count. By moving the test, we need to copy the test file with quotes. Test plan: Run t/db_dependent/Koha/Edifact/Transport.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I would squash the first 3 patches. Marcel, shouldn't we actually access the edi_files like $BIN/../../.. instead of duplicating a file? (In reply to Jonathan Druart from comment #10) > Marcel, shouldn't we actually access the edi_files like $BIN/../../.. > instead of duplicating a file? Yeah. Will adjust. Created attachment 155174 [details] [review] Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db Moving file now here. Test plan: Run t/db_dependent/Koha/Edifact/Transport.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #9) > I would squash the first 3 patches. All squashed now. Created attachment 155798 [details] [review] Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db Moving file now here. Test plan: Run t/db_dependent/Koha/Edifact/Transport.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice cleanup, Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |