Bug 34415 - Remove Test::DBIx::Class from t/EdiTransport.t
Summary: Remove Test::DBIx::Class from t/EdiTransport.t
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Marcel de Rooy
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks: 34336
  Show dependency tree / graph
 
Reported: 2023-07-26 07:28 UTC by Marcel de Rooy
Modified: 2024-07-04 20:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 34415: Remove T::D::C from EdiTransport.t (2.76 KB, patch)
2023-07-26 11:34 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 34415: Move to db_dependent (681 bytes, patch)
2023-07-26 11:34 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 34415: Perltidy file (1.99 KB, patch)
2023-07-26 11:34 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 34415: (follow-up) Fix count and copy file (9.08 KB, patch)
2023-07-26 11:34 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 34415: Remove T::D::C from EdiTransport.t (2.79 KB, patch)
2023-07-27 09:06 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34415: Move to db_dependent (715 bytes, patch)
2023-07-27 09:06 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34415: Perltidy file (2.03 KB, patch)
2023-07-27 09:06 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34415: (follow-up) Fix count and copy file (9.12 KB, patch)
2023-07-27 09:06 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db (4.05 KB, patch)
2023-09-02 13:43 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db (4.08 KB, patch)
2023-09-18 10:55 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-07-26 07:28:45 UTC 
Remove Test::DBIx::Class
Comment 1 Marcel de Rooy 2023-07-26 11:34:00 UTC 
Created attachment 153906 [details] [review]
Bug 34415: Remove T::D::C from EdiTransport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-07-26 11:34:03 UTC 
Created attachment 153907 [details] [review]
Bug 34415: Move to db_dependent

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2023-07-26 11:34:05 UTC 
Created attachment 153908 [details] [review]
Bug 34415: Perltidy file

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2023-07-26 11:34:07 UTC 
Created attachment 153909 [details] [review]
Bug 34415: (follow-up) Fix count and copy file

Instead of assuming a count of 0, I added an initial count.
By moving the test, we need to copy the test file with quotes.

Test plan:
Run t/db_dependent/Koha/Edifact/Transport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Jonathan Druart 2023-07-27 09:06:40 UTC 
Created attachment 153943 [details] [review]
Bug 34415: Remove T::D::C from EdiTransport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2023-07-27 09:06:43 UTC 
Created attachment 153944 [details] [review]
Bug 34415: Move to db_dependent

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2023-07-27 09:06:45 UTC 
Created attachment 153945 [details] [review]
Bug 34415: Perltidy file

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2023-07-27 09:06:48 UTC 
Created attachment 153946 [details] [review]
Bug 34415: (follow-up) Fix count and copy file

Instead of assuming a count of 0, I added an initial count.
By moving the test, we need to copy the test file with quotes.

Test plan:
Run t/db_dependent/Koha/Edifact/Transport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2023-07-27 09:07:02 UTC 
I would squash the first 3 patches.
Comment 10 Jonathan Druart 2023-09-01 10:17:33 UTC 
Marcel, shouldn't we actually access the edi_files like $BIN/../../.. instead of duplicating a file?
Comment 11 Marcel de Rooy 2023-09-02 12:57:02 UTC 
(In reply to Jonathan Druart from comment #10)
> Marcel, shouldn't we actually access the edi_files like $BIN/../../..
> instead of duplicating a file?

Yeah. Will adjust.
Comment 12 Marcel de Rooy 2023-09-02 13:43:16 UTC 
Created attachment 155174 [details] [review]
Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db

Moving file now here.

Test plan:
Run t/db_dependent/Koha/Edifact/Transport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Marcel de Rooy 2023-09-02 13:44:11 UTC 
(In reply to Jonathan Druart from comment #9)
> I would squash the first 3 patches.

All squashed now.
Comment 14 Martin Renvoize (ashimema) 2023-09-18 10:55:02 UTC 
Created attachment 155798 [details] [review]
Bug 34415: Remove T::D::C from EdiTransport.t, move to t/db

Moving file now here.

Test plan:
Run t/db_dependent/Koha/Edifact/Transport.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 15 Martin Renvoize (ashimema) 2023-09-18 10:55:50 UTC 
Nice cleanup, Passing QA
Comment 16 Tomás Cohen Arazi (tcohen) 2023-09-18 15:06:05 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 17 Fridolin Somers 2023-09-18 21:06:57 UTC 
Enhancement not pushed to 23.05.x