Summary: | Fix CMS page HTML structure so that footer content is displayed correctly | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Aleisha Amohia <aleisha> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dcook, fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.10
|
|
Circulation function: | |||
Bug Depends on: | 15326 | ||
Bug Blocks: | |||
Attachments: |
Bug 34627: CMS pages do not correctly display the opaccredits footer
Bug 34627: CMS pages do not correctly display the opaccredits footer Bug 34627: CMS pages do not correctly display the opaccredits footer |
Description
Aleisha Amohia
2023-08-27 22:41:12 UTC
Created attachment 154876 [details] [review] Bug 34627: CMS pages do not correctly display the opaccredits footer This patch corrects the page structure of CMS pages in the OPAC so that the contents of the footer, including opaccredits, OpacKohaUrl, and the language selection bar, are displayed correctly. This patch contains indentation changes, so ignore whitespace when viewing the diff. To test you should have these settings: - OpacKohaUrl enabled in system preferences - Some content in the opaccredits HTML customization region - Some content in the OpacNav HTML customization region - At least one translation installed and enabled - The opaclanguagesdisplay preference enabled - The OpacLangSelectorMode set to "only footer" or "both top and footer" - Apply the patch and go to Tools -> Pages and create a page with the display location "OPAC." - Open the OPAC link for your newly-created page and confirm that the page looks correct: - The "main" region with the white background should contain the breadcrumb navigation, the sidebar OpacNav content, and the contents of your CMS page. - The opaccredits and OpacKohaUrl content should appear below that region. - The language selection footer should be at the bottom of the page. Created attachment 154878 [details] [review] Bug 34627: CMS pages do not correctly display the opaccredits footer This patch corrects the page structure of CMS pages in the OPAC so that the contents of the footer, including opaccredits, OpacKohaUrl, and the language selection bar, are displayed correctly. This patch contains indentation changes, so ignore whitespace when viewing the diff. To test you should have these settings: - OpacKohaUrl enabled in system preferences - Some content in the opaccredits HTML customization region - Some content in the OpacNav HTML customization region - At least one translation installed and enabled - The opaclanguagesdisplay preference enabled - The OpacLangSelectorMode set to "only footer" or "both top and footer" - Apply the patch and go to Tools -> Pages and create a page with the display location "OPAC." - Open the OPAC link for your newly-created page and confirm that the page looks correct: - The "main" region with the white background should contain the breadcrumb navigation, the sidebar OpacNav content, and the contents of your CMS page. - The opaccredits and OpacKohaUrl content should appear below that region. - The language selection footer should be at the bottom of the page. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 154892 [details] [review] Bug 34627: CMS pages do not correctly display the opaccredits footer This patch corrects the page structure of CMS pages in the OPAC so that the contents of the footer, including opaccredits, OpacKohaUrl, and the language selection bar, are displayed correctly. This patch contains indentation changes, so ignore whitespace when viewing the diff. To test you should have these settings: - OpacKohaUrl enabled in system preferences - Some content in the opaccredits HTML customization region - Some content in the OpacNav HTML customization region - At least one translation installed and enabled - The opaclanguagesdisplay preference enabled - The OpacLangSelectorMode set to "only footer" or "both top and footer" - Apply the patch and go to Tools -> Pages and create a page with the display location "OPAC." - Open the OPAC link for your newly-created page and confirm that the page looks correct: - The "main" region with the white background should contain the breadcrumb navigation, the sidebar OpacNav content, and the contents of your CMS page. - The opaccredits and OpacKohaUrl content should appear below that region. - The language selection footer should be at the bottom of the page. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Pushed to master for 23.11. Nice work everyone, thanks! Thanks all! Can this please be backported for 23.05? Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |