Bug 34627 - Fix CMS page HTML structure so that footer content is displayed correctly
Summary: Fix CMS page HTML structure so that footer content is displayed correctly
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Aleisha Amohia
URL:
Keywords:
Depends on: 15326
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-27 22:41 UTC by Aleisha Amohia
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 34627: CMS pages do not correctly display the opaccredits footer (3.83 KB, patch)
2023-08-28 11:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34627: CMS pages do not correctly display the opaccredits footer (3.89 KB, patch)
2023-08-28 11:56 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34627: CMS pages do not correctly display the opaccredits footer (3.95 KB, patch)
2023-08-29 01:32 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2023-08-27 22:41:12 UTC
To reproduce

1. Create an HTML customisation (in Staff interface -> tools -> HTML customisations) in the 'opaccredits' section. Give it some formatting i.e colours and headings
2. Save this and confirm it displays as expected on the OPAC
3. Create a custom page (in Staff interface -> tools -> pages)
4. Save this and open it in the OPAC
5. Notice the opaccredits section does not display as normal

This is because the template for custom OPAC pages puts opaccredits inside the #main div, whereas other OPAC templates puts them outside the #main div
Comment 1 Owen Leonard 2023-08-28 11:16:18 UTC Comment hidden (obsolete)
Comment 2 Pedro Amorim 2023-08-28 11:56:13 UTC Comment hidden (obsolete)
Comment 3 Aleisha Amohia 2023-08-29 01:32:13 UTC
Created attachment 154892 [details] [review]
Bug 34627: CMS pages do not correctly display the opaccredits footer

This patch corrects the page structure of CMS pages in the OPAC so that
the contents of the footer, including opaccredits, OpacKohaUrl, and the
language selection bar, are displayed correctly.

This patch contains indentation changes, so ignore whitespace when
viewing the diff.

To test you should have these settings:

- OpacKohaUrl enabled in system preferences
- Some content in the opaccredits HTML customization region
- Some content in the OpacNav HTML customization region
- At least one translation installed and enabled
- The opaclanguagesdisplay preference enabled
- The OpacLangSelectorMode set to "only footer" or "both top and footer"

- Apply the patch and go to Tools -> Pages and create a page with the
  display location "OPAC."
- Open the OPAC link for your newly-created page and confirm that the
  page looks correct:
  - The "main" region with the white background should contain the
    breadcrumb navigation, the sidebar OpacNav content, and the contents
    of your CMS page.
  - The opaccredits and OpacKohaUrl content should appear below that
    region.
  - The language selection footer should be at the bottom of the page.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 4 Tomás Cohen Arazi 2023-08-29 17:58:47 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Aleisha Amohia 2023-08-29 21:04:54 UTC
Thanks all!

Can this please be backported for 23.05?
Comment 6 Fridolin Somers 2023-08-30 07:20:12 UTC
Pushed to 23.05.x for 23.05.04
Comment 7 Fridolin Somers 2023-08-30 07:25:18 UTC
Feature added by Bug 15326 in 22.11
Comment 8 Matt Blenkinsop 2023-08-31 10:37:22 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x