| Summary: | Font Awesome icons broken in self checkout and self checkin | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Self checkout | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 32910 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 35013: Font Awesome icons broken in self checkout and self checkin
Bug 35013: Font Awesome icons broken in self checkout and self checkin Bug 35013: Font Awesome icons broken in self checkout and self checkin Bug 35013: Font Awesome icons broken in self checkout and self checkin |
||
|
Description
Owen Leonard
2023-10-09 15:20:36 UTC
Created attachment 156747 [details] [review] Bug 35013: Font Awesome icons broken in self checkout and self checkin This patch updates the way Font Awesome icon assets are included on the self checkout and self checkin pages. This change should have been made during the upgrade to Font Awesome 6 (Bug 32910). To test, apply the patch and make sure both SelfCheckInModule and WebBasedSelfCheck system preferences are enabled. - Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log in. - Check that Font Awesome icons are working: You should see an information icon by the "Help" link in the header, and a check mark icon in the "Finish" button. - Click the help link to confirm that the icon appears there too. - Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl). - In the header you should see the information icon by the help link and an icon with the "Log out" link too. Created attachment 156751 [details] [review] Bug 35013: Font Awesome icons broken in self checkout and self checkin This patch updates the way Font Awesome icon assets are included on the self checkout and self checkin pages. This change should have been made during the upgrade to Font Awesome 6 (Bug 32910). To test, apply the patch and make sure both SelfCheckInModule and WebBasedSelfCheck system preferences are enabled. - Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log in. - Check that Font Awesome icons are working: You should see an information icon by the "Help" link in the header, and a check mark icon in the "Finish" button. - Click the help link to confirm that the icon appears there too. - Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl). - In the header you should see the information icon by the help link and an icon with the "Log out" link too. Created attachment 156761 [details] [review] Bug 35013: Font Awesome icons broken in self checkout and self checkin This patch updates the way Font Awesome icon assets are included on the self checkout and self checkin pages. This change should have been made during the upgrade to Font Awesome 6 (Bug 32910). To test, apply the patch and make sure both SelfCheckInModule and WebBasedSelfCheck system preferences are enabled. - Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log in. - Check that Font Awesome icons are working: You should see an information icon by the "Help" link in the header, and a check mark icon in the "Finish" button. - Click the help link to confirm that the icon appears there too. - Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl). - In the header you should see the information icon by the help link and an icon with the "Log out" link too. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Misusing my powers a little... ... was just about to sign off, but noticed you had already done so. Can confirm that everything works as per the test plan. (In reply to David Nind from comment #5) > ... was just about to sign off, but noticed you had already done so. Can > confirm that everything works as per the test plan. Sorry :) Please feel free to add your sign-off line too! Created attachment 156769 [details] [review] Bug 35013: Font Awesome icons broken in self checkout and self checkin This patch updates the way Font Awesome icon assets are included on the self checkout and self checkin pages. This change should have been made during the upgrade to Font Awesome 6 (Bug 32910). To test, apply the patch and make sure both SelfCheckInModule and WebBasedSelfCheck system preferences are enabled. - Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log in. - Check that Font Awesome icons are working: You should see an information icon by the "Help" link in the header, and a check mark icon in the "Finish" button. - Click the help link to confirm that the icon appears there too. - Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl). - In the header you should see the information icon by the help link and an icon with the "Log out" link too. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> (In reply to Katrin Fischer from comment #6) > (In reply to David Nind from comment #5) > > ... was just about to sign off, but noticed you had already done so. Can > > confirm that everything works as per the test plan. > > Sorry :) Please feel free to add your sign-off line too! 8-) Have added my sign-off as well... Pushed to master for 23.11. Nice work everyone, thanks! Depends on Bug 32910 not in 23.05.x |