Bug 35013 - Font Awesome icons broken in self checkout and self checkin
Summary: Font Awesome icons broken in self checkout and self checkin
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32910
Blocks:
  Show dependency tree / graph
 
Reported: 2023-10-09 15:20 UTC by Owen Leonard
Modified: 2024-07-04 20:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 35013: Font Awesome icons broken in self checkout and self checkin (2.68 KB, patch)
2023-10-09 15:36 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35013: Font Awesome icons broken in self checkout and self checkin (3.88 KB, patch)
2023-10-09 15:40 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35013: Font Awesome icons broken in self checkout and self checkin (3.93 KB, patch)
2023-10-09 19:34 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 35013: Font Awesome icons broken in self checkout and self checkin (3.98 KB, patch)
2023-10-09 21:04 UTC, David Nind 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-10-09 15:20:36 UTC 
When we upgraded Font Awesome to v6 we missed updating the way the assets are included in self checkout and self checkin.
Comment 1 Owen Leonard 2023-10-09 15:36:30 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-10-09 15:40:18 UTC 
Created attachment 156751 [details] [review]
Bug 35013: Font Awesome icons broken in self checkout and self checkin

This patch updates the way Font Awesome icon assets are included on the
self checkout and self checkin pages. This change should have been made
during the upgrade to Font Awesome 6 (Bug 32910).

To test, apply the patch and make sure both SelfCheckInModule and
WebBasedSelfCheck system preferences are enabled.

- Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log
  in.
- Check that Font Awesome icons are working: You should see an
  information icon by the "Help" link in the header, and a check mark
  icon in the "Finish" button.
- Click the help link to confirm that the icon appears there too.
- Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl).
- In the header you should see the information icon by the help link and
  an icon with the "Log out" link too.
Comment 3 Katrin Fischer 2023-10-09 19:34:12 UTC 
Created attachment 156761 [details] [review]
Bug 35013: Font Awesome icons broken in self checkout and self checkin

This patch updates the way Font Awesome icon assets are included on the
self checkout and self checkin pages. This change should have been made
during the upgrade to Font Awesome 6 (Bug 32910).

To test, apply the patch and make sure both SelfCheckInModule and
WebBasedSelfCheck system preferences are enabled.

- Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log
  in.
- Check that Font Awesome icons are working: You should see an
  information icon by the "Help" link in the header, and a check mark
  icon in the "Finish" button.
- Click the help link to confirm that the icon appears there too.
- Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl).
- In the header you should see the information icon by the help link and
  an icon with the "Log out" link too.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-10-09 19:34:51 UTC 
Misusing my powers a little...
Comment 5 David Nind 2023-10-09 19:51:28 UTC 
... was just about to sign off, but noticed you had already done so. Can confirm that everything works as per the test plan.
Comment 6 Katrin Fischer 2023-10-09 20:02:17 UTC 
(In reply to David Nind from comment #5)
> ... was just about to sign off, but noticed you had already done so. Can
> confirm that everything works as per the test plan.

Sorry :) Please feel free to add your sign-off line too!
Comment 7 David Nind 2023-10-09 21:04:05 UTC 
Created attachment 156769 [details] [review]
Bug 35013: Font Awesome icons broken in self checkout and self checkin

This patch updates the way Font Awesome icon assets are included on the
self checkout and self checkin pages. This change should have been made
during the upgrade to Font Awesome 6 (Bug 32910).

To test, apply the patch and make sure both SelfCheckInModule and
WebBasedSelfCheck system preferences are enabled.

- Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log
  in.
- Check that Font Awesome icons are working: You should see an
  information icon by the "Help" link in the header, and a check mark
  icon in the "Finish" button.
- Click the help link to confirm that the icon appears there too.
- Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl).
- In the header you should see the information icon by the help link and
  an icon with the "Log out" link too.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2023-10-09 21:04:32 UTC 
(In reply to Katrin Fischer from comment #6)
> (In reply to David Nind from comment #5)
> > ... was just about to sign off, but noticed you had already done so. Can
> > confirm that everything works as per the test plan.
> 
> Sorry :) Please feel free to add your sign-off line too!

8-) Have added my sign-off as well...
Comment 9 Tomás Cohen Arazi (tcohen) 2023-10-10 12:23:16 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2023-10-12 20:36:27 UTC 
Depends on Bug 32910 not in 23.05.x