| Summary: | Add holds to patron activity triggers | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Patrons | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, gmcharlt, kebliss, kyle, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/745 |
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 15504 | ||
| Bug Blocks: | 35001, 35030 | ||
| Attachments: |
Bug 35027: Add 'hold' to patron activity triggers
Bug 35027: Add 'hold' to patron activity triggers Bug 35027: Add 'hold' to patron activity triggers Bug 35027: Add 'hold' to patron activity triggers Bug 35027: Add 'hold' to patron activity triggers |
||
|
Description
Martin Renvoize (ashimema)
2023-10-11 12:37:06 UTC
Created attachment 156952 [details] [review] Bug 35027: Add 'hold' to patron activity triggers This patch adds 'hold' to the list of triggers available for tracking patron activity. Test plan 1) Select 'Placing a hold on an item' in the TrackPatronLastActivityTriggers system preference 2) As a staff member, place a hold on any item for a test user 3) Confirm that the borrowers.lastseen field is updated for that test borrower Created attachment 156953 [details] [review] Bug 35027: Add 'hold' to patron activity triggers This patch adds 'hold' to the list of triggers available for tracking patron activity. Test plan 1) Select 'Placing a hold on an item' in the TrackPatronLastActivityTriggers system preference 2) As a staff member, place a hold on any item for a test user 3) Confirm that the borrowers.lastseen field is updated for that test borrower FAIL valid
Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?)
Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?)
Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?)
Please run QA tools yourself ?
Ha... you grabbed it so quick you got the version before I spotted my error there. Bugger.. ignore that.. I fixed it and broke another place! Created attachment 156956 [details] [review] Bug 35027: Add 'hold' to patron activity triggers This patch adds 'hold' to the list of triggers available for tracking patron activity. Test plan 1) Select 'Placing a hold on an item' in the TrackPatronLastActivityTriggers system preference 2) As a staff member, place a hold on any item for a test user 3) Confirm that the borrowers.lastseen field is updated for that test borrower Created attachment 156960 [details] [review] Bug 35027: Add 'hold' to patron activity triggers This patch adds 'hold' to the list of triggers available for tracking patron activity. Test plan 1) Select 'Placing a hold on an item' in the TrackPatronLastActivityTriggers system preference 2) As a staff member, place a hold on any item for a test user 3) Confirm that the borrowers.lastseen field is updated for that test borrower Created attachment 156963 [details] [review] Bug 35027: Add 'hold' to patron activity triggers This patch adds 'hold' to the list of triggers available for tracking patron activity. Test plan 1) Select 'Placing a hold on an item' in the TrackPatronLastActivityTriggers system preference 2) As a staff member, place a hold on any item for a test user 3) Confirm that the borrowers.lastseen field is updated for that test borrower Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Taking liberty to pass QA in one go. Trivial enough. Pushed to master for 23.11. Nice work everyone, thanks! Depends on Bug 15504 not in 23.05.x |