Bug 35027

Summary: Add holds to patron activity triggers
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: PatronsAssignee: Martin Renvoize <martin.renvoize>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, fridolin.somers, gmcharlt, kebliss, kyle.m.hall, m.de.rooy
Version: MainKeywords: rel_23_11_candidate
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/745
Text to go in the release notes:
Version(s) released in:
23.11.00
Bug Depends on: 15504    
Bug Blocks: 35001, 35030    
Attachments: Bug 35027: Add 'hold' to patron activity triggers
Bug 35027: Add 'hold' to patron activity triggers
Bug 35027: Add 'hold' to patron activity triggers
Bug 35027: Add 'hold' to patron activity triggers
Bug 35027: Add 'hold' to patron activity triggers

Description Martin Renvoize 2023-10-11 12:37:06 UTC
If a staff member submits a hold for a patron, that may be construed as signifying the patron is active. (and may not have been caught by a login or other activity trigger already)
Comment 1 Martin Renvoize 2023-10-12 11:42:30 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2023-10-12 11:56:09 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2023-10-12 12:02:10 UTC
   FAIL   valid
                Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?)
                Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?)
                Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?)


Please run QA tools yourself ?
Comment 4 Martin Renvoize 2023-10-12 12:02:55 UTC
Ha... you grabbed it so quick you got the version before I spotted my error there.
Comment 5 Martin Renvoize 2023-10-12 12:03:35 UTC
Bugger.. ignore that.. I fixed it and broke another place!
Comment 6 Martin Renvoize 2023-10-12 12:07:37 UTC Comment hidden (obsolete)
Comment 7 Martin Renvoize 2023-10-12 12:38:34 UTC
Created attachment 156960 [details] [review]
Bug 35027: Add 'hold' to patron activity triggers

This patch adds 'hold' to the list of triggers available for tracking
patron activity.

Test plan
1) Select 'Placing a hold on an item' in the
   TrackPatronLastActivityTriggers system preference
2) As a staff member, place a hold on any item for a test user
3) Confirm that the borrowers.lastseen field is updated for that test
   borrower
Comment 8 Marcel de Rooy 2023-10-12 13:36:19 UTC
Created attachment 156963 [details] [review]
Bug 35027: Add 'hold' to patron activity triggers

This patch adds 'hold' to the list of triggers available for tracking
patron activity.

Test plan
1) Select 'Placing a hold on an item' in the
   TrackPatronLastActivityTriggers system preference
2) As a staff member, place a hold on any item for a test user
3) Confirm that the borrowers.lastseen field is updated for that test
   borrower

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2023-10-12 13:36:57 UTC
Taking liberty to pass QA in one go. Trivial enough.
Comment 10 Tomás Cohen Arazi 2023-10-24 13:06:53 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Fridolin Somers 2023-10-26 06:50:23 UTC
Depends on Bug 15504 not in 23.05.x