Bug 35027 - Add holds to patron activity triggers
Summary: Add holds to patron activity triggers
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Marcel de Rooy
URL:
Keywords: rel_23_11_candidate
Depends on: 15504
Blocks: 35001 35030
  Show dependency treegraph
 
Reported: 2023-10-11 12:37 UTC by Martin Renvoize
Modified: 2023-11-01 21:21 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/745
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 35027: Add 'hold' to patron activity triggers (1.78 KB, patch)
2023-10-12 11:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35027: Add 'hold' to patron activity triggers (2.15 KB, patch)
2023-10-12 11:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35027: Add 'hold' to patron activity triggers (2.19 KB, patch)
2023-10-12 12:07 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35027: Add 'hold' to patron activity triggers (6.43 KB, patch)
2023-10-12 12:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35027: Add 'hold' to patron activity triggers (6.52 KB, patch)
2023-10-12 13:36 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-10-11 12:37:06 UTC
If a staff member submits a hold for a patron, that may be construed as signifying the patron is active. (and may not have been caught by a login or other activity trigger already)
Comment 1 Martin Renvoize 2023-10-12 11:42:30 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2023-10-12 11:56:09 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2023-10-12 12:02:10 UTC
   FAIL   valid
                Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?)
                Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?)
                Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?)


Please run QA tools yourself ?
Comment 4 Martin Renvoize 2023-10-12 12:02:55 UTC
Ha... you grabbed it so quick you got the version before I spotted my error there.
Comment 5 Martin Renvoize 2023-10-12 12:03:35 UTC
Bugger.. ignore that.. I fixed it and broke another place!
Comment 6 Martin Renvoize 2023-10-12 12:07:37 UTC Comment hidden (obsolete)
Comment 7 Martin Renvoize 2023-10-12 12:38:34 UTC
Created attachment 156960 [details] [review]
Bug 35027: Add 'hold' to patron activity triggers

This patch adds 'hold' to the list of triggers available for tracking
patron activity.

Test plan
1) Select 'Placing a hold on an item' in the
   TrackPatronLastActivityTriggers system preference
2) As a staff member, place a hold on any item for a test user
3) Confirm that the borrowers.lastseen field is updated for that test
   borrower
Comment 8 Marcel de Rooy 2023-10-12 13:36:19 UTC
Created attachment 156963 [details] [review]
Bug 35027: Add 'hold' to patron activity triggers

This patch adds 'hold' to the list of triggers available for tracking
patron activity.

Test plan
1) Select 'Placing a hold on an item' in the
   TrackPatronLastActivityTriggers system preference
2) As a staff member, place a hold on any item for a test user
3) Confirm that the borrowers.lastseen field is updated for that test
   borrower

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2023-10-12 13:36:57 UTC
Taking liberty to pass QA in one go. Trivial enough.
Comment 10 Tomás Cohen Arazi 2023-10-24 13:06:53 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Fridolin Somers 2023-10-26 06:50:23 UTC
Depends on Bug 15504 not in 23.05.x