Bug 35030 - Extend TrackLastPatronActivity with placing article request
Summary: Extend TrackLastPatronActivity with placing article request
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Marcel de Rooy
URL:
Keywords: rel_23_11_candidate
Depends on: 15504 35027
Blocks: 35001
  Show dependency treegraph
 
Reported: 2023-10-11 14:28 UTC by Marcel de Rooy
Modified: 2023-11-01 21:22 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/745
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 35030: Add 'article' to patron activity triggers (2.09 KB, patch)
2023-10-12 11:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35030: Add 'article' to patron activity triggers (7.29 KB, patch)
2023-10-12 13:05 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35030: Add 'article' to patron activity triggers (7.07 KB, patch)
2023-10-12 13:50 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-10-11 14:28:19 UTC
See bug 15504
Comment 1 Marcel de Rooy 2023-10-11 14:43:51 UTC
Note that bug 35027 adds holds.
Comment 2 Martin Renvoize 2023-10-12 11:58:30 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2023-10-12 12:03:45 UTC
Could you please extend the unit test ?
Comment 4 Martin Renvoize 2023-10-12 13:05:12 UTC
Created attachment 156961 [details] [review]
Bug 35030: Add 'article' to patron activity triggers

This patch adds 'article' to the list of triggers available for
tracking patron activity.

Test plan
1) Select 'Placing an article request
   TrackPatronLastActivityTriggers system preference
2) As a staff member, place a hold on any item for a test user
3) Confirm that the borrowers.lastseen field is updated for that
   test borrower
Comment 5 Martin Renvoize 2023-10-12 13:07:50 UTC
Tests added :)
Comment 6 Marcel de Rooy 2023-10-12 13:50:47 UTC
Created attachment 156964 [details] [review]
Bug 35030: Add 'article' to patron activity triggers

This patch adds 'article' to the list of triggers available for
tracking patron activity.

Test plan
1) Select 'Placing an article request
   TrackPatronLastActivityTriggers system preference
2) As a staff member, place a hold on any item for a test user
3) Confirm that the borrowers.lastseen field is updated for that
   test borrower

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Marcel de Rooy 2023-10-12 13:54:05 UTC
Moving to PQA, combining with SO
Comment 8 Tomás Cohen Arazi 2023-10-23 14:36:42 UTC
Marking as BLOCKED until bug 15504 is PQA. Please adjust dependencies if this is wrong.
Comment 9 Tomás Cohen Arazi 2023-10-24 13:06:56 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2023-10-26 06:50:49 UTC
Depends on Bug 15504 not in 23.05.x