Bug 35094

Summary: ILL new request is broken
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Bugs List <koha-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P5 - low CC: fridolin.somers, katrin.fischer, lucas, martin.renvoize, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Bug Depends on: 35093    
Bug Blocks: 35105, 35106, 35107, 35096    
Attachments: Bug 35094: Update batch to ill_batch accessor in .tt file
Bug 35094: Update batch to ill_batch accessor in .tt file
Bug 35094: Update batch to ill_batch accessor in .tt file

Description Pedro Amorim 2023-10-18 15:35:33 UTC
To reproduce, k-t-d:
1) Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Visit /cgi-bin/koha/ill/ill-requests.pl
3) Create "New ILL request"
4) Select the request type, input cardnumber '42' and select a library
5) Hit 'Create'
BOOM
Comment 1 Pedro Amorim 2023-10-18 15:41:09 UTC
Created attachment 157338 [details] [review]
Bug 35094: Update batch to ill_batch accessor in .tt file

Test plan:
1) Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Visit /cgi-bin/koha/ill/ill-requests.pl
3) Create 'New ILL request'
4) Select the request type, input cardnumber '42' and select a library
5) Hit 'Create'
6) Notice the request now creates successfully
Comment 2 Tomás Cohen Arazi 2023-10-18 19:10:25 UTC
Created attachment 157353 [details] [review]
Bug 35094: Update batch to ill_batch accessor in .tt file

Test plan:
1) Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Visit /cgi-bin/koha/ill/ill-requests.pl
3) Create 'New ILL request'
4) Select the request type, input cardnumber '42' and select a library
5) Hit 'Create'
6) Notice the request now creates successfully

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Lucas Gass 2023-10-18 23:10:46 UTC
Works as described, simple fix, passing QA.
Comment 4 Lucas Gass 2023-10-18 23:11:14 UTC
Created attachment 157364 [details] [review]
Bug 35094: Update batch to ill_batch accessor in .tt file

Test plan:
1) Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Visit /cgi-bin/koha/ill/ill-requests.pl
3) Create 'New ILL request'
4) Select the request type, input cardnumber '42' and select a library
5) Hit 'Create'
6) Notice the request now creates successfully

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2023-10-19 19:02:33 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-25 08:14:41 UTC
Depends on Bug 35093 not in 23.05.x