Bug 35093 - ILL table is broken
Summary: ILL table is broken
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 30719
Blocks: 35094
  Show dependency treegraph
 
Reported: 2023-10-18 15:29 UTC by Pedro Amorim
Modified: 2023-10-25 08:13 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 35093: Update batch to ill_batch embed (1.07 KB, patch)
2023-10-18 15:30 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35093: Update batch to ill_batch embed (1.13 KB, patch)
2023-10-18 23:09 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35093: Update batch to ill_batch embed (1.19 KB, patch)
2023-10-19 10:58 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-10-18 15:29:16 UTC
Caused by last minute refactoring of 30719.

To reproduce:
Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)

Visit /cgi-bin/koha/ill/ill-requests.pl

BOOM
Comment 1 Pedro Amorim 2023-10-18 15:30:30 UTC
Created attachment 157337 [details] [review]
Bug 35093: Update batch to ill_batch embed

Test plan:

Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)

Visit /cgi-bin/koha/ill/ill-requests.pl

Notice the table now renders correctly
Comment 2 Lucas Gass 2023-10-18 23:09:26 UTC
Created attachment 157363 [details] [review]
Bug 35093: Update batch to ill_batch embed

Test plan:

Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)

Visit /cgi-bin/koha/ill/ill-requests.pl

Notice the table now renders correctly

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Martin Renvoize 2023-10-19 10:58:58 UTC
Created attachment 157419 [details] [review]
Bug 35093: Update batch to ill_batch embed

Test plan:

Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)

Visit /cgi-bin/koha/ill/ill-requests.pl

Notice the table now renders correctly

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-10-19 10:59:25 UTC
Trivial fix for major issue.

Passing QA
Comment 5 Tomás Cohen Arazi 2023-10-19 19:02:29 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-25 08:13:39 UTC
Depends on Bug 30719 not in 23.05.x