Bug 35094 - ILL new request is broken
Summary: ILL new request is broken
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on: 35093
Blocks: 35105 35106 35107 35096
  Show dependency treegraph
 
Reported: 2023-10-18 15:35 UTC by Pedro Amorim
Modified: 2023-10-25 08:14 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 35094: Update batch to ill_batch accessor in .tt file (1.53 KB, patch)
2023-10-18 15:41 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35094: Update batch to ill_batch accessor in .tt file (1.58 KB, patch)
2023-10-18 19:10 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 35094: Update batch to ill_batch accessor in .tt file (1.64 KB, patch)
2023-10-18 23:11 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-10-18 15:35:33 UTC
To reproduce, k-t-d:
1) Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Visit /cgi-bin/koha/ill/ill-requests.pl
3) Create "New ILL request"
4) Select the request type, input cardnumber '42' and select a library
5) Hit 'Create'
BOOM
Comment 1 Pedro Amorim 2023-10-18 15:41:09 UTC
Created attachment 157338 [details] [review]
Bug 35094: Update batch to ill_batch accessor in .tt file

Test plan:
1) Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Visit /cgi-bin/koha/ill/ill-requests.pl
3) Create 'New ILL request'
4) Select the request type, input cardnumber '42' and select a library
5) Hit 'Create'
6) Notice the request now creates successfully
Comment 2 Tomás Cohen Arazi 2023-10-18 19:10:25 UTC
Created attachment 157353 [details] [review]
Bug 35094: Update batch to ill_batch accessor in .tt file

Test plan:
1) Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Visit /cgi-bin/koha/ill/ill-requests.pl
3) Create 'New ILL request'
4) Select the request type, input cardnumber '42' and select a library
5) Hit 'Create'
6) Notice the request now creates successfully

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Lucas Gass 2023-10-18 23:10:46 UTC
Works as described, simple fix, passing QA.
Comment 4 Lucas Gass 2023-10-18 23:11:14 UTC
Created attachment 157364 [details] [review]
Bug 35094: Update batch to ill_batch accessor in .tt file

Test plan:
1) Install FreeForm and enable ILLmodule, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Visit /cgi-bin/koha/ill/ill-requests.pl
3) Create 'New ILL request'
4) Select the request type, input cardnumber '42' and select a library
5) Hit 'Create'
6) Notice the request now creates successfully

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2023-10-19 19:02:33 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-25 08:14:41 UTC
Depends on Bug 35093 not in 23.05.x