| Summary: | ILL request manage page explodes if it belongs to a batch | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
| Component: | ILL | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, pedro.amorim, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 35094 | ||
| Bug Blocks: | 35098 | ||
| Attachments: |
Bug 35096: Fix batch accessor in ILL request page
Bug 35096: Fix batch accessor in ILL request page Bug 35096: Fix batch accessor in ILL request page |
||
|
Description
Pedro Amorim
2023-10-18 16:07:05 UTC
Created attachment 157339 [details] [review] Bug 35096: Fix batch accessor in ILL request page Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 9) You should now be seeing 'View ILL requests for batch <batch_name>' with the request you just added. 10) Click the request id (or the 'Manage request' button) 11) Notice you can view the request correctly, the batch it belongs to shows correctly and is clickable Created attachment 157365 [details] [review] Bug 35096: Fix batch accessor in ILL request page Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 9) You should now be seeing 'View ILL requests for batch <batch_name>' with the request you just added. 10) Click the request id (or the 'Manage request' button) 11) Notice you can view the request correctly, the batch it belongs to shows correctly and is clickable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 157420 [details] [review] Bug 35096: Fix batch accessor in ILL request page Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 9) You should now be seeing 'View ILL requests for batch <batch_name>' with the request you just added. 10) Click the request id (or the 'Manage request' button) 11) Notice you can view the request correctly, the batch it belongs to shows correctly and is clickable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Another trivial fix to a major bug. QA scripts happy and code change is clear. Passing QA Pushed to master for 23.11. Nice work everyone, thanks! |