To reproduce, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 10) Go back to ILL requests table, visit: /cgi-bin/koha/ill/ill-requests.pl 11) On the top right of the table, click 'Columns' and enable Batch 12) Notice the batch column is empty for the request we just created within a batch
Created attachment 157341 [details] [review] Bug 35098: Fix display of clickable batch name in ILL table Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 10) Go back to ILL requests table, visit: /cgi-bin/koha/ill/ill-requests.pl 11) On the top right of the table, click 'Columns' and enable Batch 12) Notice the batch column now shows correctly and is clickable
Created attachment 157439 [details] [review] Bug 35098: Fix display of clickable batch name in ILL table Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 10) Go back to ILL requests table, visit: /cgi-bin/koha/ill/ill-requests.pl 11) On the top right of the table, click 'Columns' and enable Batch 12) Notice the batch column now shows correctly and is clickable Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Another trivial fix after the last minute refactoring Going straight for QA Passed.
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 35096 not in 23.05.x