|
Description
Martin Renvoize (ashimema)
2023-11-07 14:06:32 UTC
Created attachment 158599 [details] [review] Bug 35279: Add fallback to print for 'Send welcome email' We update the 'Send welcome email' button to read 'Send welcome notice' and add a fallback to enqueue a notice for print when the user doesn't have an email address defined. Test plan 1) Apply patch 2) Use the 'Henry Acevedo' user who doesn't yet have a valid email address. 3) Click the 'Send welcome notice' button available from the 'more' menu. 4) Note that no notice is queued at all. 5) Copy the content of the 'email' WELCOME notice into the 'print' template. 5) Repeat step 3. 6) Note that this time a 'print' type notice is queued for the user. Created attachment 158601 [details] [review] Bug 35279: Add fallback to print for 'Send welcome email' We update the 'Send welcome email' button to read 'Send welcome notice' and add a fallback to enqueue a notice for print when the user doesn't have an email address defined. Test plan 1) Apply patch 2) Use the 'Henry Acevedo' user who doesn't yet have a valid email address. 3) Click the 'Send welcome notice' button available from the 'more' menu. 4) Note that no notice is queued at all. 5) Copy the content of the 'email' WELCOME notice into the 'print' template. 5) Repeat step 3. 6) Note that this time a 'print' type notice is queued for the user. Created attachment 158612 [details] [review] Bug 35279: Add fallback to print for 'Send welcome email' We update the 'Send welcome email' button to read 'Send welcome notice' and add a fallback to enqueue a notice for print when the user doesn't have an email address defined. Test plan 1) Apply patch 2) Use the 'Henry Acevedo' user who doesn't yet have a valid email address. 3) Click the 'Send welcome notice' button available from the 'more' menu. 4) Note that no notice is queued at all. 5) Copy the content of the 'email' WELCOME notice into the 'print' template. 5) Repeat step 3. 6) Note that this time a 'print' type notice is queued for the user. Signed-off-by: David Nind <david@davidnind.com> Created attachment 161547 [details] [review] Bug 35279: Add fallback to print for 'Send welcome email' We update the 'Send welcome email' button to read 'Send welcome notice' and add a fallback to enqueue a notice for print when the user doesn't have an email address defined. Test plan 1) Apply patch 2) Use the 'Henry Acevedo' user who doesn't yet have a valid email address. 3) Click the 'Send welcome notice' button available from the 'more' menu. 4) Note that no notice is queued at all. 5) Copy the content of the 'email' WELCOME notice into the 'print' template. 5) Repeat step 3. 6) Note that this time a 'print' type notice is queued for the user. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x |