Bug 35279 - Add fallback for WELCOME notice to allow 'print' when patrons are missing email address
Summary: Add fallback for WELCOME notice to allow 'print' when patrons are missing ema...
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords: Sandbox
Depends on:
Blocks:
 
Reported: 2023-11-07 14:06 UTC by Martin Renvoize
Modified: 2024-01-26 17:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35279: Add fallback to print for 'Send welcome email' (2.98 KB, patch)
2023-11-07 14:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35279: Add fallback to print for 'Send welcome email' (2.99 KB, patch)
2023-11-07 14:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35279: Add fallback to print for 'Send welcome email' (3.03 KB, patch)
2023-11-07 17:37 UTC, David Nind
Details | Diff | Splinter Review
Bug 35279: Add fallback to print for 'Send welcome email' (3.09 KB, patch)
2024-01-26 17:42 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-11-07 14:06:32 UTC
When testing bug 34704 I realised it's not especially trivial to trigger a print notice to be generated.  I think it's a good idea to allow fallback to print for the WELCOME notice when calling 'Send welcome email' from the patrons profile.
Comment 1 Martin Renvoize 2023-11-07 14:12:12 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2023-11-07 14:33:52 UTC
Created attachment 158601 [details] [review]
Bug 35279: Add fallback to print for 'Send welcome email'

We update the 'Send welcome email' button to read 'Send welcome notice'
and add a fallback to enqueue a notice for print when the user doesn't
have an email address defined.

Test plan
1) Apply patch
2) Use the 'Henry Acevedo' user who doesn't yet have a valid email
   address.
3) Click the 'Send welcome notice' button available from the 'more'
   menu.
4) Note that no notice is queued at all.
5) Copy the content of the 'email' WELCOME notice into the 'print'
   template.
5) Repeat step 3.
6) Note that this time a 'print' type notice is queued for the user.
Comment 3 David Nind 2023-11-07 17:37:36 UTC
Created attachment 158612 [details] [review]
Bug 35279: Add fallback to print for 'Send welcome email'

We update the 'Send welcome email' button to read 'Send welcome notice'
and add a fallback to enqueue a notice for print when the user doesn't
have an email address defined.

Test plan
1) Apply patch
2) Use the 'Henry Acevedo' user who doesn't yet have a valid email
   address.
3) Click the 'Send welcome notice' button available from the 'more'
   menu.
4) Note that no notice is queued at all.
5) Copy the content of the 'email' WELCOME notice into the 'print'
   template.
5) Repeat step 3.
6) Note that this time a 'print' type notice is queued for the user.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Kyle M Hall 2024-01-26 17:42:52 UTC
Created attachment 161547 [details] [review]
Bug 35279: Add fallback to print for 'Send welcome email'

We update the 'Send welcome email' button to read 'Send welcome notice'
and add a fallback to enqueue a notice for print when the user doesn't
have an email address defined.

Test plan
1) Apply patch
2) Use the 'Henry Acevedo' user who doesn't yet have a valid email
   address.
3) Click the 'Send welcome notice' button available from the 'more'
   menu.
4) Note that no notice is queued at all.
5) Copy the content of the 'email' WELCOME notice into the 'print'
   template.
5) Repeat step 3.
6) Note that this time a 'print' type notice is queued for the user.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>