Bug 33260 - Show message queue on staff interface and make notices printable
Summary: Show message queue on staff interface and make notices printable
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords: Hackfest, Sandbox
: 7638 (view as bug list)
Depends on: 30287 35267 38089 33478 34030 35285
Blocks: 36809
  Show dependency treegraph
 
Reported: 2023-03-17 02:36 UTC by Aleisha Amohia
Modified: 2025-03-27 15:46 UTC (History)
15 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission.
Version(s) released in:
Circulation function:


Attachments
Bug 33260: Add view_generated_notices user permission (3.81 KB, patch)
2023-03-21 03:27 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.32 KB, patch)
2023-03-21 03:27 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.00 KB, patch)
2023-03-21 03:27 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: [WIP] Add Notice management tool (12.19 KB, patch)
2023-03-21 03:27 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: [WIP] Add Notice management tool (22.53 KB, patch)
2023-03-30 04:05 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (27.87 KB, patch)
2023-03-31 02:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.40 KB, patch)
2023-04-10 23:53 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.00 KB, patch)
2023-04-12 23:11 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.06 KB, patch)
2023-04-13 12:36 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (3.87 KB, patch)
2023-04-13 12:37 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.38 KB, patch)
2023-04-13 12:37 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.06 KB, patch)
2023-04-13 12:37 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.45 KB, patch)
2023-04-13 12:37 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.06 KB, patch)
2023-04-13 12:37 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (32.04 KB, patch)
2023-04-28 03:21 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.07 KB, patch)
2023-04-28 03:21 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (32.05 KB, patch)
2023-08-29 23:54 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.07 KB, patch)
2023-08-29 23:54 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (1.99 KB, patch)
2023-10-19 04:12 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (32.11 KB, patch)
2023-10-19 04:12 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.07 KB, patch)
2023-10-19 04:12 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Make styles apply per notice (1.46 KB, patch)
2023-10-19 04:12 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (1.99 KB, patch)
2023-11-12 23:15 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.65 KB, patch)
2023-11-12 23:15 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.07 KB, patch)
2023-11-12 23:15 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Make styles apply per notice (1.32 KB, patch)
2023-11-12 23:15 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (3.88 KB, patch)
2024-02-29 01:50 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.39 KB, patch)
2024-02-29 01:50 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (1.91 KB, patch)
2024-02-29 01:50 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.58 KB, patch)
2024-02-29 01:50 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.07 KB, patch)
2024-02-29 01:50 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.65 KB, patch)
2024-02-29 22:22 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.07 KB, patch)
2024-02-29 22:22 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (3.92 KB, patch)
2024-03-01 16:41 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.43 KB, patch)
2024-03-01 16:41 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (1.96 KB, patch)
2024-03-01 16:41 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.74 KB, patch)
2024-03-01 16:41 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.11 KB, patch)
2024-03-01 16:41 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (3.95 KB, patch)
2024-04-12 02:47 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.47 KB, patch)
2024-04-12 02:47 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.12 KB, patch)
2024-04-12 02:47 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.80 KB, patch)
2024-04-12 02:47 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.11 KB, patch)
2024-04-12 02:47 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.75 KB, patch)
2024-04-21 22:39 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.11 KB, patch)
2024-04-21 22:39 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (5.34 KB, patch)
2024-04-29 01:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.00 KB, patch)
2024-05-01 03:53 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (3.99 KB, patch)
2024-05-01 08:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.51 KB, patch)
2024-05-01 08:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.16 KB, patch)
2024-05-01 08:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.78 KB, patch)
2024-05-01 08:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.16 KB, patch)
2024-05-01 08:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.04 KB, patch)
2024-05-01 08:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.32 KB, patch)
2024-05-01 16:43 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.50 KB, patch)
2024-05-06 03:23 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (4.06 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.58 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.25 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.86 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.22 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.11 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.23 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.56 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Tidy unit test (2.26 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add template relation (1.36 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Safely continue for non-templated notices (1.55 KB, patch)
2024-05-07 18:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (4.06 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.58 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.25 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.86 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.22 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.11 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.23 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.56 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Tidy unit test (2.42 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add template relation (2.90 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Safely continue for non-templated notices (1.69 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add missing page-section (6.74 KB, patch)
2024-05-08 09:45 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (4.06 KB, patch)
2024-06-20 00:12 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.58 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.25 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.86 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.22 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.11 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.23 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.56 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: Tidy unit test (2.42 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add template relation (2.53 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Safely continue for non-templated notices (1.69 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add missing page-section (6.74 KB, patch)
2024-06-20 00:13 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 33260: (follow-up) Rebase for bootstrap 5 (2.66 KB, patch)
2024-10-01 07:17 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Remove patron search as primary action (8.54 KB, patch)
2024-10-01 08:25 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Sync functionality and ordering of display (17.75 KB, patch)
2024-10-02 13:47 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Sync functionality and ordering of display (21.81 KB, patch)
2024-10-02 16:30 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (4.07 KB, patch)
2024-10-02 16:38 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.58 KB, patch)
2024-10-02 16:38 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.23 KB, patch)
2024-10-02 16:38 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.86 KB, patch)
2024-10-02 16:38 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.22 KB, patch)
2024-10-02 16:38 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.11 KB, patch)
2024-10-02 16:38 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.23 KB, patch)
2024-10-02 16:38 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.56 KB, patch)
2024-10-02 16:38 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Tidy unit test (2.42 KB, patch)
2024-10-02 16:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add template relation (2.53 KB, patch)
2024-10-02 16:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Safely continue for non-templated notices (1.69 KB, patch)
2024-10-02 16:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add missing page-section (6.74 KB, patch)
2024-10-02 16:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Rebase for bootstrap 5 (2.66 KB, patch)
2024-10-02 16:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Remove patron search as primary action (8.54 KB, patch)
2024-10-02 16:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Sync functionality and ordering of display (21.81 KB, patch)
2024-10-02 16:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (4.07 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.58 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.23 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.86 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.22 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.11 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.23 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.56 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Tidy unit test (2.42 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add template relation (2.53 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Safely continue for non-templated notices (1.69 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add missing page-section (6.74 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Rebase for bootstrap 5 (2.66 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Remove patron search as primary action (8.54 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Sync functionality and ordering of display (23.57 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Add correct page title to print (1.15 KB, patch)
2024-10-03 14:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Limit printing to non-pending on members page (4.37 KB, patch)
2024-10-03 14:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Alternative print button in modal (2.23 KB, patch)
2024-10-03 14:36 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Correct call to 'style' (791 bytes, patch)
2024-10-04 08:19 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (4.07 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.58 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.26 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.86 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.22 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.11 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.27 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.51 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Tidy unit test (2.42 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add template relation (2.56 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Safely continue for non-templated notices (1.69 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add missing page-section (6.74 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Rebase for bootstrap 5 (2.66 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Remove patron search as primary action (8.54 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Sync functionality and ordering of display (23.57 KB, patch)
2024-12-16 16:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Add correct page title to print (1.15 KB, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Limit printing to non-pending on members page (4.37 KB, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Alternative print button in modal (2.23 KB, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Correct call to 'style' (791 bytes, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) More comprehensively test patron accessor (1.75 KB, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) More comprehensively test template accessor (1.63 KB, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Fix typo noice -> notice (1.44 KB, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Fix TT syntax failure (2.24 KB, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Replace nosort with NoSort (2.69 KB, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add hint to disabled select checkbox (1.46 KB, patch)
2024-12-16 16:32 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Also add 'print' option to modal on tools (1.95 KB, patch)
2024-12-16 17:08 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (4.07 KB, patch)
2024-12-16 18:26 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.65 KB, patch)
2024-12-16 18:26 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.25 KB, patch)
2024-12-16 18:26 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.86 KB, patch)
2024-12-16 18:26 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.22 KB, patch)
2024-12-16 18:26 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.11 KB, patch)
2024-12-16 18:26 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.25 KB, patch)
2024-12-16 18:26 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.51 KB, patch)
2024-12-16 18:26 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Tidy unit test (2.42 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add template relation (2.54 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Safely continue for non-templated notices (1.69 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add missing page-section (6.74 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Rebase for bootstrap 5 (2.66 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Remove patron search as primary action (8.54 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Sync functionality and ordering of display (23.57 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Add correct page title to print (1.15 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Limit printing to non-pending on members page (4.37 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Alternative print button in modal (2.23 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Correct call to 'style' (791 bytes, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) More comprehensively test patron accessor (1.75 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) More comprehensively test template accessor (1.63 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Fix typo noice -> notice (1.44 KB, patch)
2024-12-16 18:27 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Fix TT syntax failure (2.24 KB, patch)
2024-12-16 18:28 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Replace nosort with NoSort (2.69 KB, patch)
2024-12-16 18:28 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add hint to disabled select checkbox (1.46 KB, patch)
2024-12-16 18:28 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Also add 'print' option to modal on tools (1.95 KB, patch)
2024-12-16 18:28 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Migrate notice printing to members/print_notice (14.58 KB, patch)
2024-12-16 18:28 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (4.07 KB, patch)
2024-12-19 13:00 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.65 KB, patch)
2024-12-19 13:00 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.25 KB, patch)
2024-12-19 13:00 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (31.86 KB, patch)
2024-12-19 13:00 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.22 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.11 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.25 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.51 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Tidy unit test (2.42 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add template relation (2.54 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Safely continue for non-templated notices (1.69 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add missing page-section (6.74 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Rebase for bootstrap 5 (2.66 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Remove patron search as primary action (8.54 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Sync functionality and ordering of display (23.57 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Add correct page title to print (1.15 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Limit printing to non-pending on members page (4.37 KB, patch)
2024-12-19 13:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Alternative print button in modal (2.23 KB, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Correct call to 'style' (791 bytes, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) More comprehensively test patron accessor (1.75 KB, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) More comprehensively test template accessor (1.63 KB, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Fix typo noice -> notice (1.44 KB, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Fix TT syntax failure (2.24 KB, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Replace nosort with NoSort (2.69 KB, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add hint to disabled select checkbox (1.46 KB, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Also add 'print' option to modal on tools (1.95 KB, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Migrate notice printing to members/print_notice (14.25 KB, patch)
2024-12-19 13:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add view_generated_notices user permission (4.50 KB, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add NoticesManagement system preference (3.91 KB, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add a patron getter method to Koha::Notice::Message (2.05 KB, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add Notice management tool (32.39 KB, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Move patron search into main body of page (3.48 KB, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Fix search forms on notices mgmt page (6.27 KB, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Correct relation accessor and add unit test (2.25 KB, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Use search_limited to protect message privacy, and unit test (4.44 KB, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Tidy unit test (750 bytes, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add template relation (2.54 KB, patch)
2025-02-26 16:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Safely continue for non-templated notices (1.69 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (QA follow-up) Add missing page-section (8.13 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Rebase for bootstrap 5 (2.84 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Remove patron search as primary action (11.17 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Sync functionality and ordering of display (33.89 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Add correct page title to print (4.99 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Limit printing to non-pending on members page (3.68 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Alternative print button in modal (2.06 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Correct call to 'style' (791 bytes, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) More comprehensively test patron accessor (1.75 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) More comprehensively test template accessor (1.63 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Fix typo noice -> notice (1.36 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Fix TT syntax failure (1.75 KB, patch)
2025-02-26 16:41 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Replace nosort with NoSort (2.66 KB, patch)
2025-02-26 16:42 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Add hint to disabled select checkbox (1.37 KB, patch)
2025-02-26 16:42 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: (follow-up) Also add 'print' option to modal on tools (1.95 KB, patch)
2025-02-26 16:42 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 33260: Migrate notice printing to members/print_notice (14.10 KB, patch)
2025-02-26 16:42 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2023-03-17 02:36:15 UTC
Some Koha libraries need to get messages out to borrowers who do not have email addresses, so they need to be able to view generated notices, and optionally print them so they can be delivered offline.
Comment 1 Aleisha Amohia 2023-03-21 03:27:07 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2023-03-21 03:27:10 UTC Comment hidden (obsolete)
Comment 3 Aleisha Amohia 2023-03-21 03:27:12 UTC Comment hidden (obsolete)
Comment 4 Aleisha Amohia 2023-03-21 03:27:15 UTC Comment hidden (obsolete)
Comment 5 Aleisha Amohia 2023-03-30 04:05:08 UTC Comment hidden (obsolete)
Comment 6 Aleisha Amohia 2023-03-31 02:56:06 UTC Comment hidden (obsolete)
Comment 7 Aleisha Amohia 2023-04-10 23:53:21 UTC
Created attachment 149413 [details] [review]
Bug 33260: Add Notice management tool

This enhancement makes it easy for the library to view sent notices and filter by various search parameters.

You can also print sent notices, individually or in a batch.

This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission.

To test:
1. Apply patches, install database updates, restart services
2. Make sure your logged in user has the view_generated_notices permission checked
3. Enable the NoticesManagement system preference
4. Generate a few notices. There are a few ways to do this including:
- place holds, check in items and confirm the holds
- place recalls, check in items and confirm the recalls
5. Go to Tools -> Notices management
6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history.
7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters.
8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct.
9. Click on a notice title. Confirm the contents of the notice show in a pop-up box.
10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed.
11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'.
12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes.
13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'.
14. Confirm the Notices management page is not visible without the view_generated_notices permission
15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled.
16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference.

Sponsored-by: Colorado Library Consortium
Comment 8 Laura Escamilla 2023-04-11 12:20:40 UTC
Hi!

Overall the new syspref and notices management page is working as expected. However, there are a few things I noticed that seem to be a little broken. 

1. In the Notices Management page if you search for a patron and their name populates then clicking on the populated name will appropriately take you to their notice history. However, if you use the "Browse by last name" option or if you just search for a letter such as "K", then the table that is supposed to show the patron names is not displayed properly. It is askew to the left and mixes into the filter options. 

2. The print notices work, but there is a lot of whitespace within the messages. This might be a separate bug, but having the messages more condensed and still separated by the horizontal line would be ideal.
Comment 9 Aleisha Amohia 2023-04-12 22:53:45 UTC
Thank you for testing Laura!

(In reply to Laura Escamilla from comment #8)
> Hi!
> 
> Overall the new syspref and notices management page is working as expected.
> However, there are a few things I noticed that seem to be a little broken. 
> 
> 1. In the Notices Management page if you search for a patron and their name
> populates then clicking on the populated name will appropriately take you to
> their notice history. However, if you use the "Browse by last name" option
> or if you just search for a letter such as "K", then the table that is
> supposed to show the patron names is not displayed properly. It is askew to
> the left and mixes into the filter options. 
> 

I'll work on fixing this.

> 2. The print notices work, but there is a lot of whitespace within the
> messages. This might be a separate bug, but having the messages more
> condensed and still separated by the horizontal line would be ideal.

This is just how the default HOLD print notice comes in Koha, it has heaps of line breaks in it. You can go to Notices & slips and delete the newlines from the template notice to remove that whitespace.
Comment 10 Aleisha Amohia 2023-04-12 23:11:53 UTC Comment hidden (obsolete)
Comment 11 ByWater Sandboxes 2023-04-13 12:36:09 UTC Comment hidden (obsolete)
Comment 12 ByWater Sandboxes 2023-04-13 12:37:18 UTC Comment hidden (obsolete)
Comment 13 ByWater Sandboxes 2023-04-13 12:37:20 UTC Comment hidden (obsolete)
Comment 14 ByWater Sandboxes 2023-04-13 12:37:21 UTC Comment hidden (obsolete)
Comment 15 ByWater Sandboxes 2023-04-13 12:37:23 UTC Comment hidden (obsolete)
Comment 16 ByWater Sandboxes 2023-04-13 12:37:25 UTC Comment hidden (obsolete)
Comment 17 Laura Escamilla 2023-04-13 12:38:10 UTC
Love the way the new setup looks for the notice management page!
Comment 18 Aleisha Amohia 2023-04-28 03:21:32 UTC Comment hidden (obsolete)
Comment 19 Aleisha Amohia 2023-04-28 03:21:35 UTC Comment hidden (obsolete)
Comment 20 Aleisha Amohia 2023-04-28 03:22:50 UTC
I've rebased this to build on top of Bug 33478 and use the format settings. Only the patch "Bug 33260: Add Notice management tool" needs to be re-tested and a new sign-off line added.
Comment 21 Emmi Takkinen 2023-08-17 07:54:12 UTC
I'm getting this error when trying to apply the patches:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 33260: Add view_generated_notices user permission
Applying: Bug 33260: Add NoticesManagement system preference
Applying: Bug 33260: Add a patron getter method to Koha::Notice::Message
Applying: Bug 33260: Add Notice management tool
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
M	koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
A	koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js deleted in HEAD and modified in Bug 33260: Add Notice management tool. Version Bug 33260: Add Notice management tool of koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js left in tree.
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 33260: Add Notice management tool
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-33260-Add-Notice-management-tool-wp4ViP.patch
Comment 22 Aleisha Amohia 2023-08-29 23:54:43 UTC Comment hidden (obsolete)
Comment 23 Aleisha Amohia 2023-08-29 23:54:46 UTC Comment hidden (obsolete)
Comment 24 David Nind 2023-09-25 00:17:00 UTC
Patch no longer applies 8-(...

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 33260: Add view_generated_notices user permission
Applying: Bug 33260: Add NoticesManagement system preference
Applying: Bug 33260: Add a patron getter method to Koha::Notice::Message
Using index info to reconstruct a base tree...
M	t/db_dependent/Letters.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters.t
CONFLICT (content): Merge conflict in t/db_dependent/Letters.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 33260: Add a patron getter method to Koha::Notice::Message
Comment 25 Aleisha Amohia 2023-10-19 04:12:03 UTC Comment hidden (obsolete)
Comment 26 Aleisha Amohia 2023-10-19 04:12:06 UTC Comment hidden (obsolete)
Comment 27 Aleisha Amohia 2023-10-19 04:12:09 UTC Comment hidden (obsolete)
Comment 28 Aleisha Amohia 2023-10-19 04:12:12 UTC Comment hidden (obsolete)
Comment 29 Aleisha Amohia 2023-10-19 04:16:33 UTC
The latest patch uses regex to replace all the CSS selectors when printing notices from the Notices Management page. It's not perfect, but it does the best job (that I could find) at applying notice-specific styles when printing a batch of notices.
Comment 30 Kelly McElligott 2023-10-20 15:30:00 UTC
Upon testing this, I am getting, for every notice, I try to print, No Slip Template Found.  Each notice that I have tested has a template created which include checkin, hold, checkout, welcome. 

Not sure why I am getting this message.
Comment 31 Kelly McElligott 2023-10-20 15:39:01 UTC
Upon testing this, I am getting, for every notice, I try to print, No Slip Template Found.  Each notice that I have tested has a template created which include checkin, hold, checkout, welcome. 

Not sure why I am getting this message.
Comment 32 Aleisha Amohia 2023-10-29 20:57:12 UTC
Hi Kelly,

I think you may have been seeing that message if you forgot to apply the patches from Bug 33478 first.

Bug 33478 now needs to be rebased so will update when this patchset can be tested again.
Comment 33 Aleisha Amohia 2023-11-12 23:15:21 UTC Comment hidden (obsolete)
Comment 34 Aleisha Amohia 2023-11-12 23:15:24 UTC Comment hidden (obsolete)
Comment 35 Aleisha Amohia 2023-11-12 23:15:27 UTC Comment hidden (obsolete)
Comment 36 Aleisha Amohia 2023-11-12 23:15:30 UTC Comment hidden (obsolete)
Comment 37 Aleisha Amohia 2023-11-12 23:16:15 UTC
I have reworked this feature to apply on top of the new Preservation Module, which changed the markup for how most notices are sent.

Please test that any formatting applies to all notices again, thank you!
Comment 38 Martin Renvoize (ashimema) 2023-11-13 11:28:39 UTC
Just starting to look here; just a couple of comments from initial testing so far

* Could you take bug 30287 into account for the notice previews, please?
* I used bug 35279 to test using the WELCOME message (it adds print fallback)
  Once I'd created a print type welcome notice for the ktd henry user, it displayed OK in print preview from the new notice management page, but the same print button on the patron notices tab yields 'No slip template found'.

I must admit, I find the print process a little confusing at the moment, but need to test more before really commenting further.  I do however like the idea of the feature overall.. will be watching it closeing during the next cycle.
Comment 39 Martin Renvoize (ashimema) 2023-11-13 17:03:12 UTC
Comment on attachment 158855 [details] [review]
Bug 33260: Make styles apply per notice

Review of attachment 158855 [details] [review]:
-----------------------------------------------------------------

I think this patch belongs in bug 33478 personally.. it's a fix for that bug not this one after rebases.

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt
@@ +39,5 @@
>      [% SET slips = [{content => slip, is_html => !plain, style => style }] %]
>  [% END %]
>  [% FOR slip IN slips %]
> +[% IF slip.style %]<style>[% slip.style.replace('[^{]+{', '#slip_' _ slip.id _ ' {') | $raw %]</style>[% END %]
> +<span id="slip_[% slip.id | html %]">

Also.. this should really be a block level element in my opinion rather than an inline level element.. Probably a 'div'.
Comment 40 Aleisha Amohia 2024-02-29 01:50:04 UTC Comment hidden (obsolete)
Comment 41 Aleisha Amohia 2024-02-29 01:50:08 UTC Comment hidden (obsolete)
Comment 42 Aleisha Amohia 2024-02-29 01:50:11 UTC Comment hidden (obsolete)
Comment 43 Aleisha Amohia 2024-02-29 01:50:15 UTC Comment hidden (obsolete)
Comment 44 Aleisha Amohia 2024-02-29 01:50:18 UTC Comment hidden (obsolete)
Comment 45 Kelly McElligott 2024-02-29 13:35:47 UTC
When searching for a notice in the search filters within the Notice Management Tool, several notices appear multiple times.  For example, there are 3 HOLD notices.  In the sandbox I am testing in, there is only one HOLD notice within the Notices and Slips, so it shouldn't appear three times.  In addition, there are two check-in digest and two checkout digest options in this drop-down menu.  There are many that only appear once, but some appear more than once. I think that the notice should only appear once when the library only has one notice.  This list becomes very long with duplicates and it is very confusing. 

Just testing, I did create a library-specific HOLD notice, which appeared in the dropdown menu as with all the others with no indication of it being a library-specific notice.
Comment 46 Aleisha Amohia 2024-02-29 22:22:42 UTC Comment hidden (obsolete)
Comment 47 Aleisha Amohia 2024-02-29 22:22:46 UTC Comment hidden (obsolete)
Comment 48 Aleisha Amohia 2024-02-29 22:23:48 UTC
(In reply to Kelly McElligott from comment #45)
> When searching for a notice in the search filters within the Notice
> Management Tool, several notices appear multiple times.  For example, there
> are 3 HOLD notices.  In the sandbox I am testing in, there is only one HOLD
> notice within the Notices and Slips, so it shouldn't appear three times.  In
> addition, there are two check-in digest and two checkout digest options in
> this drop-down menu.  There are many that only appear once, but some appear
> more than once. I think that the notice should only appear once when the
> library only has one notice.  This list becomes very long with duplicates
> and it is very confusing. 
> 
> Just testing, I did create a library-specific HOLD notice, which appeared in
> the dropdown menu as with all the others with no indication of it being a
> library-specific notice.

Good catch, this was because of the many message transport types that might be available for a notice. I've fixed that up in latest patches - please test again when you can.
Comment 49 ByWater Sandboxes 2024-03-01 16:41:23 UTC Comment hidden (obsolete)
Comment 50 ByWater Sandboxes 2024-03-01 16:41:26 UTC Comment hidden (obsolete)
Comment 51 ByWater Sandboxes 2024-03-01 16:41:28 UTC Comment hidden (obsolete)
Comment 52 ByWater Sandboxes 2024-03-01 16:41:30 UTC Comment hidden (obsolete)
Comment 53 ByWater Sandboxes 2024-03-01 16:41:33 UTC Comment hidden (obsolete)
Comment 54 Lucas Gass (lukeg) 2024-04-11 15:28:30 UTC
Tests are failing here and the DBUpdates need to have their file permissions corrected. 

Otherwise looks good!
Comment 55 Aleisha Amohia 2024-04-12 02:47:13 UTC Comment hidden (obsolete)
Comment 56 Aleisha Amohia 2024-04-12 02:47:16 UTC Comment hidden (obsolete)
Comment 57 Aleisha Amohia 2024-04-12 02:47:19 UTC Comment hidden (obsolete)
Comment 58 Aleisha Amohia 2024-04-12 02:47:23 UTC Comment hidden (obsolete)
Comment 59 Aleisha Amohia 2024-04-12 02:47:26 UTC Comment hidden (obsolete)
Comment 60 Lucas Gass (lukeg) 2024-04-18 22:37:15 UTC
Needs rebased on top of Bug 36490 now.
Comment 61 Aleisha Amohia 2024-04-21 22:39:38 UTC Comment hidden (obsolete)
Comment 62 Aleisha Amohia 2024-04-21 22:39:42 UTC Comment hidden (obsolete)
Comment 63 David Nind 2024-04-22 08:18:27 UTC
I could not test steps 5-13 (Tools > Notices management) because I get these errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF protection) (other steps all work as expected):

1. Patron search: entering a partial name doesn't come up with the full name and card number to select (for example: start typing mary). Two errors in the console:

jQuery.Deferred exception: Cannot set properties of undefined (setting '_renderItem') TypeError: Cannot set properties of undefined (setting '_renderItem')
    at patron_autocomplete (http://127.0.0.1:8081/intranet-tmpl/prog/js/staff-global_23.1200025.js:574:46)
    at HTMLDocument.<anonymous> (http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl:2803:21)
    at e (http://127.0.0.1:8081/intranet-tmpl/lib/jquery/jquery-3.6.0.min_23.1200025.js:2:30038)
    at t (http://127.0.0.1:8081/intranet-tmpl/lib/jquery/jquery-3.6.0.min_23.1200025.js:2:30340) undefined

Uncaught TypeError: Cannot set properties of undefined (setting '_renderItem')
    at patron_autocomplete (staff-global_23.1200025.js:574:46)
    at HTMLDocument.<anonymous> (notices.pl:2803:21)
    at e (jquery-3.6.0.min_23.1200025.js:2:30038)
    at t (jquery-3.6.0.min_23.1200025.js:2:30340)

2. Browse by last name: selecting any letter displays all patrons ("showing 1 to 20 of 53 entries").

3. Selecting a patron (after choosing a letter) - nothing displays apart from the patrons search/browse by last name box) (for example: http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl?&borrowernumber=49)

4. Error when using the search filters. Click 'Search' (no need to change any filter options), error displayed:

An error has occurred!
Error 403
Programming error - op 'search' must start with 'cud-' for POST http://127.0.0.1:8081/intranet/tools/notices.pl (referer: http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl?&borrowernumber=49)
Comment 64 Aleisha Amohia 2024-04-29 01:56:30 UTC Comment hidden (obsolete)
Comment 65 Aleisha Amohia 2024-04-29 02:04:58 UTC
(In reply to David Nind from comment #63)
> I could not test steps 5-13 (Tools > Notices management) because I get these
> errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF
> protection) (other steps all work as expected):
> 

Thanks for testing David, I believe I have addressed these errors in the latest follow up.
Comment 66 David Nind 2024-04-29 05:29:57 UTC
(In reply to Aleisha Amohia from comment #65)
> (In reply to David Nind from comment #63)
> > I could not test steps 5-13 (Tools > Notices management) because I get these
> > errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF
> > protection) (other steps all work as expected):
> > 
> 
> Thanks for testing David, I believe I have addressed these errors in the
> latest follow up.

Thanks Aleisha for updating!

The patron search block on the notices management tool page is now working.

However, for the search filters on the left, I'm still getting an error when clicking on 'Search':

  An error has occurred!
  Error 403
  Programming error - op 'search' must start with 'cud-' for POST http://127.0.0.1:8081/intranet/tools/notices.pl (referer: http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl)
Comment 67 Aleisha Amohia 2024-05-01 03:53:28 UTC Comment hidden (obsolete)
Comment 68 David Nind 2024-05-01 08:26:26 UTC Comment hidden (obsolete)
Comment 69 David Nind 2024-05-01 08:26:30 UTC Comment hidden (obsolete)
Comment 70 David Nind 2024-05-01 08:26:33 UTC Comment hidden (obsolete)
Comment 71 David Nind 2024-05-01 08:26:37 UTC Comment hidden (obsolete)
Comment 72 David Nind 2024-05-01 08:26:41 UTC Comment hidden (obsolete)
Comment 73 David Nind 2024-05-01 08:26:44 UTC Comment hidden (obsolete)
Comment 74 David Nind 2024-05-01 09:09:52 UTC
Thanks for fixing Aleisha!

This looks great, and things worked as set out in the test plan.

Some things I noticed and some suggestions (but not showstoppers for me):
1. Background for search results - I think this needs the white background div.
2. Step 13 - each notice was on a separate page, I didn't notice any horizontal lines.
3. Search filters: maybe this should also have a clear button or link beside the search button.
4. Search results display after printing selected notices. If you select multiple notices and click "Print selected notices", after you have saved the PDF and returned to the notices management screen, items are still selected, the print selected notices button is still selected, and the status stays as pending. Once you do another search or refresh the page, things display as expected. Is there a way to refresh the page once the selected notices are printed?

Testing notes (using KTD):
1. I added an email address to the patron(s) I generated the notices for.
2. I updated the patron messaging preferences for the patron(s) I generated the notices for (I enabled item check-in and item checkout).
Comment 75 Martin Renvoize (ashimema) 2024-05-01 16:43:12 UTC Comment hidden (obsolete)
Comment 76 Martin Renvoize (ashimema) 2024-05-01 16:53:06 UTC
Still looking here.. must admit I'm a little disappointed to find it all coded in a style we've long since moved away from even though it's a very recent project in the grand scheme.

I'm worried about performance.. that table fills up with notice quickly and we're not paging or using API's.

Also, we now have non-template driven notices and those cause a spectacular error on attempting to print.

It looks like you're generating the notice from scratch at print time rather than using the notice that exists.. that also feels odd.. it could lead to viewing the preview and then printing something entirely different to what you just previewed.

Anyway.. I'll come back to this asap once I've dug a little further.
Comment 77 Aleisha Amohia 2024-05-01 20:59:20 UTC
(In reply to Martin Renvoize from comment #76)
> Still looking here.. must admit I'm a little disappointed to find it all
> coded in a style we've long since moved away from even though it's a very
> recent project in the grand scheme.
> 
It was an oversight, I started this development over a year ago but I know that standard has been in place for a while so my apologies.

The API and datatables stuff has moved on quite a lot since we first started using it and it isn't documented well in the wiki, so unfortunately sometimes I do need to make mistakes and be corrected. I really appreciate any specific comments or feedback I can implement here, or links to the wiki which explains the standards for these things.
Comment 78 Martin Renvoize (ashimema) 2024-05-02 08:43:11 UTC
I'm a little worried about data privacy here I'm afraid.. I think I would expect to see use of Koha::Patrons->search_limited to limit results to patrons the logged-in user has the right to see.

I'd be interested to get some feedback on that from a wider audience
Comment 79 Nick Clemens (kidclamp) 2024-05-02 15:05:08 UTC
Our team looked here as well.

I think the privacy concern is the hard block here - if search_limited was implemented here (similar to Koha::ArticleRequests::search_limited) to limit the messages to patrons who the user can view this could move ahead.

Martin's comment about non-templated notices should be addressed as well.

We agree too that we need to improve the documentation and guidelines for datatables/searching/API interactions and will add that to the next dev meeting agenda
Comment 80 Aleisha Amohia 2024-05-06 03:23:49 UTC Comment hidden (obsolete)
Comment 81 Aleisha Amohia 2024-05-06 03:24:38 UTC
Thanks for the comments, I've attached a new patch implementing Koha::Notice::Messages->search_limited.

I'm not sure what you mean by non-templated notices - are you able to give me an example of this please?
Comment 82 Martin Renvoize (ashimema) 2024-05-07 18:48:17 UTC Comment hidden (obsolete)
Comment 83 Martin Renvoize (ashimema) 2024-05-07 18:48:22 UTC Comment hidden (obsolete)
Comment 84 Martin Renvoize (ashimema) 2024-05-07 18:48:26 UTC Comment hidden (obsolete)
Comment 85 Martin Renvoize (ashimema) 2024-05-07 18:48:31 UTC Comment hidden (obsolete)
Comment 86 Martin Renvoize (ashimema) 2024-05-07 18:48:35 UTC Comment hidden (obsolete)
Comment 87 Martin Renvoize (ashimema) 2024-05-07 18:48:38 UTC Comment hidden (obsolete)
Comment 88 Martin Renvoize (ashimema) 2024-05-07 18:48:42 UTC Comment hidden (obsolete)
Comment 89 Martin Renvoize (ashimema) 2024-05-07 18:48:46 UTC Comment hidden (obsolete)
Comment 90 Martin Renvoize (ashimema) 2024-05-07 18:48:49 UTC Comment hidden (obsolete)
Comment 91 Martin Renvoize (ashimema) 2024-05-07 18:48:53 UTC Comment hidden (obsolete)
Comment 92 Martin Renvoize (ashimema) 2024-05-07 18:48:57 UTC Comment hidden (obsolete)
Comment 93 Martin Renvoize (ashimema) 2024-05-07 18:54:33 UTC
I've added some follow-ups..
1) Tidy the new unit test for search_limited
2) Add a relation (Still need to add a unit test for this) for 'template' from the Koha::Notice::Message class
3) To safely degrade rather than throw a nasty 500 error to screen when a notice doesn't have a corresponding template (Try the new 'Add message - email' functionality from the patron details page to see the 500)

Still a little more to do here and I will continue tomorrow (It's 8pm here already).

We need that unit test adding for the new relation I introduce.. but I also want to investigate how the styling works together with a mix of HTML and non-HTML notices.. also interested in seeing how SlipCSS works with this as I'm surprised to now see it using the circ/print-slip template.. I thought that was very much intended for slip printers where as I thought this particular feature was more about printing notices to a Letter/A4 size printer.. especially 'email' notices.. does it also work with other message transport type notices?
Comment 94 Martin Renvoize (ashimema) 2024-05-07 19:45:21 UTC
Maybe look into batch/print-notices.tt template instead of circ/print-slip.tt here.. though I still don't understand how the new CSS per template can possibly work here the way this is written.
Comment 95 Martin Renvoize (ashimema) 2024-05-08 09:00:18 UTC
(In reply to Martin Renvoize from comment #94)
> Maybe look into batch/print-notices.tt template instead of
> circ/print-slip.tt here.. though I still don't understand how the new CSS
> per template can possibly work here the way this is written.

OK.. Whilst I think batch/print-notices.tt is better suited here, I do see that the localised CSS stuff is accounted for in circ/print-slip.tt and SlipCSS is seldom used in my experience.

For now, I think this is OK as is but I would like to tidy up in the future as part of bug 36809
Comment 96 Martin Renvoize (ashimema) 2024-05-08 09:02:35 UTC
Now I'm asking if the choice of columns/fields displayed and their order was a deliberate choice on the Notice management page..

I'd expect them to align with those displayed in the single patron display table.. especially the feedback for send failures etc.
Comment 97 Martin Renvoize (ashimema) 2024-05-08 09:45:14 UTC Comment hidden (obsolete)
Comment 98 Martin Renvoize (ashimema) 2024-05-08 09:45:18 UTC Comment hidden (obsolete)
Comment 99 Martin Renvoize (ashimema) 2024-05-08 09:45:22 UTC Comment hidden (obsolete)
Comment 100 Martin Renvoize (ashimema) 2024-05-08 09:45:27 UTC Comment hidden (obsolete)
Comment 101 Martin Renvoize (ashimema) 2024-05-08 09:45:31 UTC Comment hidden (obsolete)
Comment 102 Martin Renvoize (ashimema) 2024-05-08 09:45:35 UTC Comment hidden (obsolete)
Comment 103 Martin Renvoize (ashimema) 2024-05-08 09:45:38 UTC Comment hidden (obsolete)
Comment 104 Martin Renvoize (ashimema) 2024-05-08 09:45:42 UTC Comment hidden (obsolete)
Comment 105 Martin Renvoize (ashimema) 2024-05-08 09:45:46 UTC Comment hidden (obsolete)
Comment 106 Martin Renvoize (ashimema) 2024-05-08 09:45:50 UTC Comment hidden (obsolete)
Comment 107 Martin Renvoize (ashimema) 2024-05-08 09:45:53 UTC Comment hidden (obsolete)
Comment 108 Martin Renvoize (ashimema) 2024-05-08 09:45:57 UTC Comment hidden (obsolete)
Comment 109 Martin Renvoize (ashimema) 2024-05-08 09:56:43 UTC
I've burnt through too much time here already but still don't feel this is quite ready and it's too close to hard feature freeze for this cycle in my opinion.

# Notices management page
* I don't understand why we start with a patron search up front and centre.. we already have a powerful patron search and replicating that code here seems to detract from the main purpose of the tool which is to display a list of notices filtered by things other than patron.
* Once a notice search is performed, I think the table column order should match that from the synonymous page in the patron record.

# Patron notices page

# Both
* Should print really appear for all transport types and message statuses?
* Should print really print an email notice using the email template, especially when there might be a print template designed specifically for print?
* Should we really be using the 'Slip' printing code rather than 'Notice' printing here?
* Should the permissions not reflect that they expose access to printing functionality rather than view functionality?
* I'm not sure that calling the print dialog should set the notice to 'sent'.. you can easily cancel before the print actually happens and so the updated status is a misrepresentation.


With all those open questions and ongoing work elsewhere to try and clean up the notices and slips code I feel this still needs more work.
Comment 110 Sylvain Def. 2024-06-19 08:24:29 UTC
CONFLICT (content): Merge conflict in t/db_dependent/Letters.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 33260: Add a patron getter method to Koha::Notice::Message
Comment 111 Aleisha Amohia 2024-06-20 00:12:56 UTC Comment hidden (obsolete)
Comment 112 Aleisha Amohia 2024-06-20 00:13:00 UTC Comment hidden (obsolete)
Comment 113 Aleisha Amohia 2024-06-20 00:13:04 UTC Comment hidden (obsolete)
Comment 114 Aleisha Amohia 2024-06-20 00:13:08 UTC Comment hidden (obsolete)
Comment 115 Aleisha Amohia 2024-06-20 00:13:12 UTC Comment hidden (obsolete)
Comment 116 Aleisha Amohia 2024-06-20 00:13:16 UTC Comment hidden (obsolete)
Comment 117 Aleisha Amohia 2024-06-20 00:13:20 UTC Comment hidden (obsolete)
Comment 118 Aleisha Amohia 2024-06-20 00:13:24 UTC Comment hidden (obsolete)
Comment 119 Aleisha Amohia 2024-06-20 00:13:28 UTC Comment hidden (obsolete)
Comment 120 Aleisha Amohia 2024-06-20 00:13:32 UTC Comment hidden (obsolete)
Comment 121 Aleisha Amohia 2024-06-20 00:13:36 UTC Comment hidden (obsolete)
Comment 122 Aleisha Amohia 2024-06-20 00:13:40 UTC Comment hidden (obsolete)
Comment 123 Martin Renvoize (ashimema) 2024-10-01 07:17:20 UTC Comment hidden (obsolete)
Comment 124 Martin Renvoize (ashimema) 2024-10-01 08:25:58 UTC Comment hidden (obsolete)
Comment 125 Martin Renvoize (ashimema) 2024-10-02 13:47:06 UTC Comment hidden (obsolete)
Comment 126 Martin Renvoize (ashimema) 2024-10-02 13:50:48 UTC
Still working here.. I'm thinking the individual print may be more consistent to just have available from the modal display as we do in a few other places and that, to me, makes it clearer we're printing whats displayed as apposed to using the print notice (I'd love to see a 'convert to print' at a later date to handle adding address details etc to such notices)

I need to work out why resend isn't working as expected.. I think that's a regression that predates this patchset somewhere however.

We're much closer again now.
Comment 127 Martin Renvoize (ashimema) 2024-10-02 16:30:51 UTC Comment hidden (obsolete)
Comment 128 Martin Renvoize (ashimema) 2024-10-02 16:38:29 UTC Comment hidden (obsolete)
Comment 129 Martin Renvoize (ashimema) 2024-10-02 16:38:33 UTC Comment hidden (obsolete)
Comment 130 Martin Renvoize (ashimema) 2024-10-02 16:38:37 UTC Comment hidden (obsolete)
Comment 131 Martin Renvoize (ashimema) 2024-10-02 16:38:41 UTC Comment hidden (obsolete)
Comment 132 Martin Renvoize (ashimema) 2024-10-02 16:38:46 UTC Comment hidden (obsolete)
Comment 133 Martin Renvoize (ashimema) 2024-10-02 16:38:50 UTC Comment hidden (obsolete)
Comment 134 Martin Renvoize (ashimema) 2024-10-02 16:38:54 UTC Comment hidden (obsolete)
Comment 135 Martin Renvoize (ashimema) 2024-10-02 16:38:58 UTC Comment hidden (obsolete)
Comment 136 Martin Renvoize (ashimema) 2024-10-02 16:39:01 UTC Comment hidden (obsolete)
Comment 137 Martin Renvoize (ashimema) 2024-10-02 16:39:05 UTC Comment hidden (obsolete)
Comment 138 Martin Renvoize (ashimema) 2024-10-02 16:39:09 UTC Comment hidden (obsolete)
Comment 139 Martin Renvoize (ashimema) 2024-10-02 16:39:14 UTC Comment hidden (obsolete)
Comment 140 Martin Renvoize (ashimema) 2024-10-02 16:39:18 UTC Comment hidden (obsolete)
Comment 141 Martin Renvoize (ashimema) 2024-10-02 16:39:22 UTC Comment hidden (obsolete)
Comment 142 Martin Renvoize (ashimema) 2024-10-02 16:39:26 UTC Comment hidden (obsolete)
Comment 143 Martin Renvoize (ashimema) 2024-10-02 16:42:59 UTC
OK.. I think I've handled all the issues I was worried about bar one..

I still think setting the status to 'sent' doesn't feel right.. I'd rather not set that and allow printing as it's own distinct action.  It might be nice to have a 'printed' record somewhere, but I think it's misleading to set an SMS or email to 'sent' when it's in fact failed to send and has instead been printed or printed as an extra action after already having been sent... maybe adding to the delivery note could help there as an alternative.

Finally.. I'm wondering if dropping the 'Actions' column and having the print button inside the preview modal would be cleaner given we already have the option to 'Resend' embedded inside that.. if not maybe we could have both Print and Resent as options in the Actions column.

Anywho.. I'll continue here tomorrow.
Comment 144 AspenCat Team 2024-10-02 16:47:35 UTC
The idea of marking things sent was to have a way to distinguish what had been printed and what had not.  So duplicate notices are not printed and delivered.  If there is a better way of noting that printing has taken place, that doesn't mislead as "sent" that would cover the functionality that is needed. - Bob
Comment 145 Aleisha Amohia 2024-10-02 19:56:39 UTC
Thanks Martin, Nick and Bob! If I can be of any help let me know.
Comment 146 Nick Clemens (kidclamp) 2024-10-02 20:27:25 UTC
(In reply to Martin Renvoize (ashimema) from comment #143)
> I still think setting the status to 'sent' doesn't feel right.. I'd rather
> not set that and allow printing as it's own distinct action.  It might be
> nice to have a 'printed' record somewhere, but I think it's misleading to
> set an SMS or email to 'sent' when it's in fact failed to send and has
> instead been printed or printed as an extra action after already having been
> sent... maybe adding to the delivery note could help there as an alternative.

I think 'sent' can be the low bar here, making it optional would be nice, but like Bob said, having a way to know what was printed is good.

Marking print as 'sent' mirrors the gather print notices, and allows this tool as a drop in replacement, staff accessible, for that cron.

I think a followup bug for adding 'printed' to the status enum would be excellent
Comment 147 Martin Renvoize (ashimema) 2024-10-02 21:05:16 UTC
Thanks for the replies everyone.

I'm sold in the marking as sent, that makes sense, especially when a notice is coming from 'pending' and is a 'print' type notice in the first place.  The query comes from those notices that appear in these two pages that are already in another state and especially those that are not 'print' type.  Makeing them sent when they were pending will prevent emails from going out for example.. though I suppose it does make sense if they're in a failure state and you want to use print as a fallback.  Anyway, I'm happy to accept 'sent' for all.

I do have another couple of questions however.

In the bulk select and print process, each notice is printed without any additional spacing between, all on one page one after the other.

Should we not add page breaks between notices so you have a notice per page (gather_print_notices appears to have lost this page breaking functionality somewhere along the line :( )

Do we also need to consider including headers here with address details etc. For print type notices we usually include physical address details right in the notice, but when printing an email type notice you currently won't get any addressee detail.. for a bulk print this would get confusing quickly I think. (This could be done in a follow-up bug perhaps.. or we could limit to print type notices for the print functionality at first?)

The thing I'm finding hard to fully understand here is the mix of notice transport types all in this one print option.  If the transport type was 'print' it makes a fair bit of sense because you usually have address details as part of the notice itself.. if it was an email then you won't get any addressee details at all in most notices with this print option.  I can see it being nice to individually print a copy of an email notice upon request or when email has failed. Again, adding this header support could perhaps be a follow-up bug a this stage.

Finally, I've been trying to dry out our printing code, but this itbeoduces yet another printslip controller that's almost a copy paste of the 6+ existing scripts.. why not use members/printnotice.pl which I was trying to keep as a simple single place for printing slips so we stop adding new functionality and then forgetting to replicated I. The 6+ clones of code?  I'll look at doing that here to save me the job of later removing that scriot again.
Comment 148 Aleisha Amohia 2024-10-02 21:56:13 UTC
Thanks Martin for your questions!

(In reply to Martin Renvoize (ashimema) from comment #147)
> I do have another couple of questions however.
> 
> In the bulk select and print process, each notice is printed without any
> additional spacing between, all on one page one after the other.
> 
> Should we not add page breaks between notices so you have a notice per page
> (gather_print_notices appears to have lost this page breaking functionality
> somewhere along the line :( )

That would be great. I remember finding it hard to make that work but I can't remember why - please feel free to give it a go!

> 
> Do we also need to consider including headers here with address details etc.
> For print type notices we usually include physical address details right in
> the notice, but when printing an email type notice you currently won't get
> any addressee detail.. for a bulk print this would get confusing quickly I
> think. (This could be done in a follow-up bug perhaps.. or we could limit to
> print type notices for the print functionality at first?)

Perhaps for email type notices we could include something like the patron-title.inc at the top?

> 
> The thing I'm finding hard to fully understand here is the mix of notice
> transport types all in this one print option.  If the transport type was
> 'print' it makes a fair bit of sense because you usually have address
> details as part of the notice itself.. if it was an email then you won't get
> any addressee details at all in most notices with this print option.  I can
> see it being nice to individually print a copy of an email notice upon
> request or when email has failed. Again, adding this header support could
> perhaps be a follow-up bug a this stage.

Email type notices were included here because in the case of CLiC, Koha is being used for libraries where patrons don't have email addresses but still want to generate notices that Koha defaults to email for.

> 
> Finally, I've been trying to dry out our printing code, but this itbeoduces
> yet another printslip controller that's almost a copy paste of the 6+
> existing scripts.. why not use members/printnotice.pl which I was trying to
> keep as a simple single place for printing slips so we stop adding new
> functionality and then forgetting to replicated I. The 6+ clones of code? 
> I'll look at doing that here to save me the job of later removing that
> scriot again.

I can't remember why I did this - maybe to allow for printing multiple at once, or to include updating the status of the notice, without breaking existing behaviour.

Really happy for you to squash the scripts.
Comment 149 Martin Renvoize (ashimema) 2024-10-03 14:35:00 UTC Comment hidden (obsolete)
Comment 150 Martin Renvoize (ashimema) 2024-10-03 14:35:04 UTC Comment hidden (obsolete)
Comment 151 Martin Renvoize (ashimema) 2024-10-03 14:35:08 UTC Comment hidden (obsolete)
Comment 152 Martin Renvoize (ashimema) 2024-10-03 14:35:12 UTC Comment hidden (obsolete)
Comment 153 Martin Renvoize (ashimema) 2024-10-03 14:35:16 UTC Comment hidden (obsolete)
Comment 154 Martin Renvoize (ashimema) 2024-10-03 14:35:20 UTC Comment hidden (obsolete)
Comment 155 Martin Renvoize (ashimema) 2024-10-03 14:35:24 UTC Comment hidden (obsolete)
Comment 156 Martin Renvoize (ashimema) 2024-10-03 14:35:28 UTC Comment hidden (obsolete)
Comment 157 Martin Renvoize (ashimema) 2024-10-03 14:35:31 UTC Comment hidden (obsolete)
Comment 158 Martin Renvoize (ashimema) 2024-10-03 14:35:35 UTC Comment hidden (obsolete)
Comment 159 Martin Renvoize (ashimema) 2024-10-03 14:35:39 UTC Comment hidden (obsolete)
Comment 160 Martin Renvoize (ashimema) 2024-10-03 14:35:43 UTC Comment hidden (obsolete)
Comment 161 Martin Renvoize (ashimema) 2024-10-03 14:35:46 UTC Comment hidden (obsolete)
Comment 162 Martin Renvoize (ashimema) 2024-10-03 14:35:50 UTC Comment hidden (obsolete)
Comment 163 Martin Renvoize (ashimema) 2024-10-03 14:35:54 UTC Comment hidden (obsolete)
Comment 164 Martin Renvoize (ashimema) 2024-10-03 14:35:58 UTC Comment hidden (obsolete)
Comment 165 Martin Renvoize (ashimema) 2024-10-03 14:36:01 UTC Comment hidden (obsolete)
Comment 166 Martin Renvoize (ashimema) 2024-10-03 14:36:05 UTC Comment hidden (obsolete)
Comment 167 Martin Renvoize (ashimema) 2024-10-03 15:32:32 UTC
*** Bug 7638 has been marked as a duplicate of this bug. ***
Comment 168 Martin Renvoize (ashimema) 2024-10-04 08:19:29 UTC Comment hidden (obsolete)
Comment 169 Jonathan Druart 2024-10-23 10:57:45 UTC
Very quick code review and testing:
1. Koha::Notice::Message->patron
+    return unless $patron_rs;
This is not tested

2. Koha::Notice::Message->template
+    return unless $template_rs;
Same

3. QA script failures 
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
    FAIL   tt_valid                              lines 75
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/tools/notices.tt
    FAIL   spelling                                                                                        
                 noice ==> noise, nice, notice              

4.
  <th class="nosort">&nbsp;</th>

+                "aoColumnDefs": [
+                    { 'bSortable': false, 'aTargets': [ 'nosort' ] }
+                ],

You should use .NoSort on the th and don't need the aoColumnDefs.

5. members/notices.pl?borrowernumber=5
Without entry we should not show the table but "There are no notices for this patron" instead.

6. "Pending" notices have their checkbox disabled, we should display a onmouseover tooltip.

7. if you print a notice that was "failed", it's then "sent" but the "delivery note" failure is still displayed on the template. Does it make sense?

8. Is it expected to print using "email" mtt, shouldn't we use the "print" template instead?

9. 2 different outputs:
 * Using "Print" from the actions column
http://localhost:8081/cgi-bin/koha/tools/print_notice.pl?message_ids=73
Using CHECKIN, all on one line
"The following items have been checked out: E Street shuffle Thank you for visiting Centerville."
 * Using "Print" from the modal
http://localhost:8081/cgi-bin/koha/members/notices.pl?borrowernumber=5
"Checkouts
The following items have been checked out:
E Street shuffle
Thank you for visiting Centerville."

Also the name of the pdf in the second example is "notices.pl.pdf"

10. "Resend" - Shouldn't we actually enqueue another message in order to keep track of what have been failed/sent?
Comment 170 Martin Renvoize (ashimema) 2024-12-16 16:31:00 UTC Comment hidden (obsolete)
Comment 171 Martin Renvoize (ashimema) 2024-12-16 16:31:04 UTC Comment hidden (obsolete)
Comment 172 Martin Renvoize (ashimema) 2024-12-16 16:31:09 UTC Comment hidden (obsolete)
Comment 173 Martin Renvoize (ashimema) 2024-12-16 16:31:13 UTC Comment hidden (obsolete)
Comment 174 Martin Renvoize (ashimema) 2024-12-16 16:31:18 UTC Comment hidden (obsolete)
Comment 175 Martin Renvoize (ashimema) 2024-12-16 16:31:23 UTC Comment hidden (obsolete)
Comment 176 Martin Renvoize (ashimema) 2024-12-16 16:31:26 UTC Comment hidden (obsolete)
Comment 177 Martin Renvoize (ashimema) 2024-12-16 16:31:30 UTC Comment hidden (obsolete)
Comment 178 Martin Renvoize (ashimema) 2024-12-16 16:31:34 UTC Comment hidden (obsolete)
Comment 179 Martin Renvoize (ashimema) 2024-12-16 16:31:39 UTC Comment hidden (obsolete)
Comment 180 Martin Renvoize (ashimema) 2024-12-16 16:31:43 UTC Comment hidden (obsolete)
Comment 181 Martin Renvoize (ashimema) 2024-12-16 16:31:47 UTC Comment hidden (obsolete)
Comment 182 Martin Renvoize (ashimema) 2024-12-16 16:31:51 UTC Comment hidden (obsolete)
Comment 183 Martin Renvoize (ashimema) 2024-12-16 16:31:55 UTC Comment hidden (obsolete)
Comment 184 Martin Renvoize (ashimema) 2024-12-16 16:31:59 UTC Comment hidden (obsolete)
Comment 185 Martin Renvoize (ashimema) 2024-12-16 16:32:03 UTC Comment hidden (obsolete)
Comment 186 Martin Renvoize (ashimema) 2024-12-16 16:32:07 UTC Comment hidden (obsolete)
Comment 187 Martin Renvoize (ashimema) 2024-12-16 16:32:11 UTC Comment hidden (obsolete)
Comment 188 Martin Renvoize (ashimema) 2024-12-16 16:32:15 UTC Comment hidden (obsolete)
Comment 189 Martin Renvoize (ashimema) 2024-12-16 16:32:20 UTC Comment hidden (obsolete)
Comment 190 Martin Renvoize (ashimema) 2024-12-16 16:32:24 UTC Comment hidden (obsolete)
Comment 191 Martin Renvoize (ashimema) 2024-12-16 16:32:28 UTC Comment hidden (obsolete)
Comment 192 Martin Renvoize (ashimema) 2024-12-16 16:32:32 UTC Comment hidden (obsolete)
Comment 193 Martin Renvoize (ashimema) 2024-12-16 16:32:36 UTC Comment hidden (obsolete)
Comment 194 Martin Renvoize (ashimema) 2024-12-16 16:32:41 UTC Comment hidden (obsolete)
Comment 195 Martin Renvoize (ashimema) 2024-12-16 17:08:46 UTC Comment hidden (obsolete)
Comment 196 Martin Renvoize (ashimema) 2024-12-16 17:19:08 UTC
(In reply to Jonathan Druart from comment #169)
> Very quick code review and testing:
> 1. Koha::Notice::Message->patron
> +    return unless $patron_rs;
> This is not tested

Fixed in yet another follow-up

> 2. Koha::Notice::Message->template
> +    return unless $template_rs;

Also fixed in yet another follow-up

> 3. QA script failures 
>  FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
>     FAIL   tt_valid                              lines 75
>  FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/tools/notices.tt
>     FAIL   spelling                                                         
> 
>                  noice ==> noise, nice, notice              

Also fixed in a follow-up

> 4.
>   <th class="nosort">&nbsp;</th>
> 
> +                "aoColumnDefs": [
> +                    { 'bSortable': false, 'aTargets': [ 'nosort' ] }
> +                ],
> 
> You should use .NoSort on the th and don't need the aoColumnDefs.

Also fixed in a follow-up

> 5. members/notices.pl?borrowernumber=5
> Without entry we should not show the table but "There are no notices for
> this patron" instead.

This is already the case

> 6. "Pending" notices have their checkbox disabled, we should display a
> onmouseover tooltip.

Fixed in a follow-up

> 7. if you print a notice that was "failed", it's then "sent" but the
> "delivery note" failure is still displayed on the template. Does it make
> sense?

I raise this earlier in the thread of discussion and agree but I also don't really know what the answer is... I think we aught to handle print and other transports independently.. if it's print and it's printed yes, see it to sent.. if it's anything else perhaps add 'printed' to either the status or the delivery notes

> 8. Is it expected to print using "email" mtt, shouldn't we use the "print"
> template instead?

Also raised above in discussion.. the objective I think was to allow printing existing notices already queued.. it's hard to 'convert to print' as we don't have the original objects data to hand after a message has been queued.

> 9. 2 different outputs:
>  * Using "Print" from the actions column
> http://localhost:8081/cgi-bin/koha/tools/print_notice.pl?message_ids=73
> Using CHECKIN, all on one line
> "The following items have been checked out: E Street shuffle Thank you for
> visiting Centerville."
>  * Using "Print" from the modal
> http://localhost:8081/cgi-bin/koha/members/notices.pl?borrowernumber=5
> "Checkouts
> The following items have been checked out:
> E Street shuffle
> Thank you for visiting Centerville."

I asked about this above.. they use different printing methods.. the modal preview applies CSS and then you print the modal content.. the print from the actions hits a print controller on the server to load a whole new page.

> Also the name of the pdf in the second example is "notices.pl.pdf"

I'd missed this
 
> 10. "Resend" - Shouldn't we actually enqueue another message in order to
> keep track of what have been failed/sent?

Resend predates all this work.. I don't know the answer but I think that should be dealt with in a distinct bug.. personally I think this should have been two bugs at least already.. one for display and a second for print handling.. the recent additions to notices and template handling with CSS and things have really complicated and confused matters for end users in my opinion and I'm just trying to work through and clarify those in the bug tree beyond this bug.
Comment 197 Martin Renvoize (ashimema) 2024-12-16 18:26:22 UTC Comment hidden (obsolete)
Comment 198 Martin Renvoize (ashimema) 2024-12-16 18:26:27 UTC Comment hidden (obsolete)
Comment 199 Martin Renvoize (ashimema) 2024-12-16 18:26:32 UTC Comment hidden (obsolete)
Comment 200 Martin Renvoize (ashimema) 2024-12-16 18:26:37 UTC Comment hidden (obsolete)
Comment 201 Martin Renvoize (ashimema) 2024-12-16 18:26:42 UTC Comment hidden (obsolete)
Comment 202 Martin Renvoize (ashimema) 2024-12-16 18:26:46 UTC Comment hidden (obsolete)
Comment 203 Martin Renvoize (ashimema) 2024-12-16 18:26:51 UTC Comment hidden (obsolete)
Comment 204 Martin Renvoize (ashimema) 2024-12-16 18:26:55 UTC Comment hidden (obsolete)
Comment 205 Martin Renvoize (ashimema) 2024-12-16 18:27:00 UTC Comment hidden (obsolete)
Comment 206 Martin Renvoize (ashimema) 2024-12-16 18:27:04 UTC Comment hidden (obsolete)
Comment 207 Martin Renvoize (ashimema) 2024-12-16 18:27:09 UTC Comment hidden (obsolete)
Comment 208 Martin Renvoize (ashimema) 2024-12-16 18:27:13 UTC Comment hidden (obsolete)
Comment 209 Martin Renvoize (ashimema) 2024-12-16 18:27:18 UTC Comment hidden (obsolete)
Comment 210 Martin Renvoize (ashimema) 2024-12-16 18:27:23 UTC Comment hidden (obsolete)
Comment 211 Martin Renvoize (ashimema) 2024-12-16 18:27:27 UTC Comment hidden (obsolete)
Comment 212 Martin Renvoize (ashimema) 2024-12-16 18:27:32 UTC Comment hidden (obsolete)
Comment 213 Martin Renvoize (ashimema) 2024-12-16 18:27:36 UTC Comment hidden (obsolete)
Comment 214 Martin Renvoize (ashimema) 2024-12-16 18:27:41 UTC Comment hidden (obsolete)
Comment 215 Martin Renvoize (ashimema) 2024-12-16 18:27:45 UTC Comment hidden (obsolete)
Comment 216 Martin Renvoize (ashimema) 2024-12-16 18:27:49 UTC Comment hidden (obsolete)
Comment 217 Martin Renvoize (ashimema) 2024-12-16 18:27:53 UTC Comment hidden (obsolete)
Comment 218 Martin Renvoize (ashimema) 2024-12-16 18:27:58 UTC Comment hidden (obsolete)
Comment 219 Martin Renvoize (ashimema) 2024-12-16 18:28:02 UTC Comment hidden (obsolete)
Comment 220 Martin Renvoize (ashimema) 2024-12-16 18:28:07 UTC Comment hidden (obsolete)
Comment 221 Martin Renvoize (ashimema) 2024-12-16 18:28:11 UTC Comment hidden (obsolete)
Comment 222 Martin Renvoize (ashimema) 2024-12-16 18:28:16 UTC Comment hidden (obsolete)
Comment 223 Martin Renvoize (ashimema) 2024-12-16 18:28:21 UTC Comment hidden (obsolete)
Comment 224 Martin Renvoize (ashimema) 2024-12-16 18:43:50 UTC
Re-order bugs so we aren't holding up an important CSS preferences clarification bug and in the hopes that gets this one moving again too.. it should make some of the testing of style output clearer in this bug having the other bug apply first instead of second.
Comment 225 Martin Renvoize (ashimema) 2024-12-19 13:00:42 UTC Comment hidden (obsolete)
Comment 226 Martin Renvoize (ashimema) 2024-12-19 13:00:47 UTC Comment hidden (obsolete)
Comment 227 Martin Renvoize (ashimema) 2024-12-19 13:00:53 UTC Comment hidden (obsolete)
Comment 228 Martin Renvoize (ashimema) 2024-12-19 13:00:58 UTC Comment hidden (obsolete)
Comment 229 Martin Renvoize (ashimema) 2024-12-19 13:01:02 UTC Comment hidden (obsolete)
Comment 230 Martin Renvoize (ashimema) 2024-12-19 13:01:07 UTC Comment hidden (obsolete)
Comment 231 Martin Renvoize (ashimema) 2024-12-19 13:01:11 UTC Comment hidden (obsolete)
Comment 232 Martin Renvoize (ashimema) 2024-12-19 13:01:16 UTC Comment hidden (obsolete)
Comment 233 Martin Renvoize (ashimema) 2024-12-19 13:01:20 UTC Comment hidden (obsolete)
Comment 234 Martin Renvoize (ashimema) 2024-12-19 13:01:25 UTC Comment hidden (obsolete)
Comment 235 Martin Renvoize (ashimema) 2024-12-19 13:01:30 UTC Comment hidden (obsolete)
Comment 236 Martin Renvoize (ashimema) 2024-12-19 13:01:34 UTC Comment hidden (obsolete)
Comment 237 Martin Renvoize (ashimema) 2024-12-19 13:01:39 UTC Comment hidden (obsolete)
Comment 238 Martin Renvoize (ashimema) 2024-12-19 13:01:44 UTC Comment hidden (obsolete)
Comment 239 Martin Renvoize (ashimema) 2024-12-19 13:01:48 UTC Comment hidden (obsolete)
Comment 240 Martin Renvoize (ashimema) 2024-12-19 13:01:53 UTC Comment hidden (obsolete)
Comment 241 Martin Renvoize (ashimema) 2024-12-19 13:01:57 UTC Comment hidden (obsolete)
Comment 242 Martin Renvoize (ashimema) 2024-12-19 13:02:02 UTC Comment hidden (obsolete)
Comment 243 Martin Renvoize (ashimema) 2024-12-19 13:02:06 UTC Comment hidden (obsolete)
Comment 244 Martin Renvoize (ashimema) 2024-12-19 13:02:11 UTC Comment hidden (obsolete)
Comment 245 Martin Renvoize (ashimema) 2024-12-19 13:02:15 UTC Comment hidden (obsolete)
Comment 246 Martin Renvoize (ashimema) 2024-12-19 13:02:20 UTC Comment hidden (obsolete)
Comment 247 Martin Renvoize (ashimema) 2024-12-19 13:02:25 UTC Comment hidden (obsolete)
Comment 248 Martin Renvoize (ashimema) 2024-12-19 13:02:29 UTC Comment hidden (obsolete)
Comment 249 Martin Renvoize (ashimema) 2024-12-19 13:02:33 UTC Comment hidden (obsolete)
Comment 250 Martin Renvoize (ashimema) 2024-12-19 13:02:38 UTC Comment hidden (obsolete)
Comment 251 Martin Renvoize (ashimema) 2024-12-19 13:02:43 UTC Comment hidden (obsolete)
Comment 252 Martin Renvoize (ashimema) 2025-02-26 16:40:19 UTC Comment hidden (obsolete)
Comment 253 Martin Renvoize (ashimema) 2025-02-26 16:40:24 UTC Comment hidden (obsolete)
Comment 254 Martin Renvoize (ashimema) 2025-02-26 16:40:29 UTC Comment hidden (obsolete)
Comment 255 Martin Renvoize (ashimema) 2025-02-26 16:40:34 UTC Comment hidden (obsolete)
Comment 256 Martin Renvoize (ashimema) 2025-02-26 16:40:38 UTC Comment hidden (obsolete)
Comment 257 Martin Renvoize (ashimema) 2025-02-26 16:40:42 UTC Comment hidden (obsolete)
Comment 258 Martin Renvoize (ashimema) 2025-02-26 16:40:47 UTC Comment hidden (obsolete)
Comment 259 Martin Renvoize (ashimema) 2025-02-26 16:40:51 UTC Comment hidden (obsolete)
Comment 260 Martin Renvoize (ashimema) 2025-02-26 16:40:55 UTC Comment hidden (obsolete)
Comment 261 Martin Renvoize (ashimema) 2025-02-26 16:40:59 UTC Comment hidden (obsolete)
Comment 262 Martin Renvoize (ashimema) 2025-02-26 16:41:03 UTC Comment hidden (obsolete)
Comment 263 Martin Renvoize (ashimema) 2025-02-26 16:41:08 UTC Comment hidden (obsolete)
Comment 264 Martin Renvoize (ashimema) 2025-02-26 16:41:13 UTC Comment hidden (obsolete)
Comment 265 Martin Renvoize (ashimema) 2025-02-26 16:41:17 UTC Comment hidden (obsolete)
Comment 266 Martin Renvoize (ashimema) 2025-02-26 16:41:21 UTC Comment hidden (obsolete)
Comment 267 Martin Renvoize (ashimema) 2025-02-26 16:41:26 UTC Comment hidden (obsolete)
Comment 268 Martin Renvoize (ashimema) 2025-02-26 16:41:30 UTC Comment hidden (obsolete)
Comment 269 Martin Renvoize (ashimema) 2025-02-26 16:41:34 UTC Comment hidden (obsolete)
Comment 270 Martin Renvoize (ashimema) 2025-02-26 16:41:38 UTC Comment hidden (obsolete)
Comment 271 Martin Renvoize (ashimema) 2025-02-26 16:41:43 UTC Comment hidden (obsolete)
Comment 272 Martin Renvoize (ashimema) 2025-02-26 16:41:47 UTC Comment hidden (obsolete)
Comment 273 Martin Renvoize (ashimema) 2025-02-26 16:41:51 UTC Comment hidden (obsolete)
Comment 274 Martin Renvoize (ashimema) 2025-02-26 16:41:55 UTC Comment hidden (obsolete)
Comment 275 Martin Renvoize (ashimema) 2025-02-26 16:42:00 UTC Comment hidden (obsolete)
Comment 276 Martin Renvoize (ashimema) 2025-02-26 16:42:05 UTC Comment hidden (obsolete)
Comment 277 Martin Renvoize (ashimema) 2025-02-26 16:42:09 UTC Comment hidden (obsolete)
Comment 278 Martin Renvoize (ashimema) 2025-02-26 16:42:13 UTC Comment hidden (obsolete)
Comment 279 Martin Renvoize (ashimema) 2025-02-26 16:48:28 UTC
Just another rebase to keep it applying