| Summary: | 'Accept essential cookies' should always appear if CookieConsent is enabled | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | OPAC | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aude.charillon, fridolin.somers, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 35347 | ||
| Bug Blocks: | 35348 | ||
| Attachments: |
Bug 35346: Update template logic to display 'Essential'
Bug 35346: Update template logic to display 'Essential' Bug 35346: Update template logic to display 'Essential' |
||
|
Description
Martin Renvoize (ashimema)
2023-11-16 11:12:52 UTC
Created attachment 159050 [details] [review] Bug 35346: Update template logic to display 'Essential' This patch updates the cookie consent template logic to always display the 'Accept essential cookies' button and only expose the 'Accept all cookies' button when there are additional cookies to accept, i.e. when JSConsents is populated. Test plan 1) Enable CookieConsent 2) Note you see 'Accept essential cookies' in both OPAC and Staff client until you have accepted them 3) Add a cookie to ConsentJS 4) Note that you will now see 'Accept all cookies' as well as the 'Accept essential cookies' button. Created attachment 159137 [details] [review] Bug 35346: Update template logic to display 'Essential' This patch updates the cookie consent template logic to always display the 'Accept essential cookies' button and only expose the 'Accept all cookies' button when there are additional cookies to accept, i.e. when JSConsents is populated. Test plan 1) Enable CookieConsent 2) Note you see 'Accept essential cookies' in both OPAC and Staff client until you have accepted them 3) Add a cookie to ConsentJS 4) Note that you will now see 'Accept all cookies' as well as the 'Accept essential cookies' button. Signed-off-by: David Nind <david@davidnind.com> All good for me. Waiting for transitive dependency bug 34793. Created attachment 162059 [details] [review] Bug 35346: Update template logic to display 'Essential' This patch updates the cookie consent template logic to always display the 'Accept essential cookies' button and only expose the 'Accept all cookies' button when there are additional cookies to accept, i.e. when JSConsents is populated. Test plan 1) Enable CookieConsent 2) Note you see 'Accept essential cookies' in both OPAC and Staff client until you have accepted them 3) Add a cookie to ConsentJS 4) Note that you will now see 'Accept all cookies' as well as the 'Accept essential cookies' button. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! |