Bug 35348 - Cookie information should be available regardless of whether you are logged in or not
Summary: Cookie information should be available regardless of whether you are logged i...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Martin Renvoize
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 35346
Blocks: 36003 36077
  Show dependency treegraph
 
Reported: 2023-11-16 11:23 UTC by Martin Renvoize
Modified: 2024-05-22 12:34 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00


Attachments
Bug 35348: Add cookies link to opac footer (8.31 KB, patch)
2023-11-16 17:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Add cookies link to opac footer (7.62 KB, patch)
2023-11-17 11:27 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Ensure users can access cookie details in staff client (1.66 KB, patch)
2023-11-17 11:27 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Remove cookie consents link from opac consents (3.80 KB, patch)
2023-11-17 11:27 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Add cookies link to opac footer (7.62 KB, patch)
2023-11-17 15:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Ensure users can access cookie details in staff client (1.66 KB, patch)
2023-11-17 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Remove cookie consents link from opac consents (3.80 KB, patch)
2023-11-17 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Add cookies link to opac footer (7.66 KB, patch)
2023-12-01 12:01 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35348: Ensure users can access cookie details in staff client (1.71 KB, patch)
2023-12-01 12:01 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35348: Remove cookie consents link from opac consents (3.84 KB, patch)
2023-12-01 12:01 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35348: Add cookies link to opac footer (7.67 KB, patch)
2024-04-25 16:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Ensure users can access cookie details in staff client (1.71 KB, patch)
2024-04-25 16:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Remove cookie consents link from opac consents (3.85 KB, patch)
2024-04-25 16:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35348: Add cookies link to opac footer (7.76 KB, patch)
2024-04-26 09:44 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35348: Ensure users can access cookie details in staff client (1.80 KB, patch)
2024-04-26 09:44 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35348: Remove cookie consents link from opac consents (3.94 KB, patch)
2024-04-26 09:44 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-11-16 11:23:52 UTC
When CookieConsent is enabled, the 'More information' button prompts a modal that contains details of what cookies are being used and why.

This information is then available from the 'Consents' tab for logged in users, but is entirely hidden for users who have accepted/denied cookies but not yet logged in.

We should move the cookie consents display out of the 'Consents' tab in the user profile and into a link from a permanent footer at the bottom of the page (next to where language selection appear when enabled would be perfect)
Comment 1 Martin Renvoize 2023-11-16 17:25:45 UTC
Created attachment 159059 [details] [review]
Bug 35348: Add cookies link to opac footer

This patch adds a link to prompt the cookies info dialogue into the opac
footer when the CookieConsent feature is enabled.
Comment 2 Martin Renvoize 2023-11-16 17:28:06 UTC
Work in progress here.. still more work to do and a test plan to follow
Comment 3 Martin Renvoize 2023-11-17 11:27:38 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2023-11-17 11:27:41 UTC Comment hidden (obsolete)
Comment 5 Martin Renvoize 2023-11-17 11:27:43 UTC Comment hidden (obsolete)
Comment 6 Martin Renvoize 2023-11-17 15:40:58 UTC
Created attachment 159091 [details] [review]
Bug 35348: Add cookies link to opac footer

This patch adds a link that opens the cookies info dialogue to the opac
footer when the CookieConsent feature is enabled.

Test plan
1) Enable CookieConsent
2) On the OPAC you should now see a 'Cookies' link at the bottom of the
   page.
3) Clicking the link should open the "Cookie consent" modal where you
   can see the details of the cookies you have accepted and change your
   choices.
4) Bonus points: Enable 'OpacProblemReports' and note it aligns left of
   'Cookies' in the same footer bar.
Comment 7 Martin Renvoize 2023-11-17 15:41:00 UTC
Created attachment 159092 [details] [review]
Bug 35348: Ensure users can access cookie details in staff client

We remove the check on JSConsents content so that when cookie consent is
enabled we retain the option for users to get more information about
what cookies are being used.

Test plan
1) Enable CookieConsents
2) Do not add any tracking cookies for the staff client into
   CookieConsentedJS preference
3) Note that 'My consents' appears in the user menu
4) Clicking 'My consents' opens the 'Cookie consent' modal displaying
   information about the cookies used.
Comment 8 Martin Renvoize 2023-11-17 15:41:03 UTC
Created attachment 159093 [details] [review]
Bug 35348: Remove cookie consents link from opac consents

The cookies details modal is now visible for all users from a footer
link, we no longer need it under the 'Consents' tab for logged in users.

Test plan
1) Enable CookieConsent and add a placholder tracker cookie to
   CookieConsentedJS preference
2) Log into the OPAC
3) Note that the 'Consents' link no longer appears in the users page.
4) Enable 'PrivacyPolicyConsent'
5) Note that the 'Consents' link now appears but on navigating to it
   there is no link for Cookie consents.
Comment 9 Owen Leonard 2023-12-01 12:01:27 UTC
Created attachment 159444 [details] [review]
Bug 35348: Add cookies link to opac footer

This patch adds a link that opens the cookies info dialogue to the opac
footer when the CookieConsent feature is enabled.

Test plan
1) Enable CookieConsent
2) On the OPAC you should now see a 'Cookies' link at the bottom of the
   page.
3) Clicking the link should open the "Cookie consent" modal where you
   can see the details of the cookies you have accepted and change your
   choices.
4) Bonus points: Enable 'OpacProblemReports' and note it aligns left of
   'Cookies' in the same footer bar.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 10 Owen Leonard 2023-12-01 12:01:29 UTC
Created attachment 159445 [details] [review]
Bug 35348: Ensure users can access cookie details in staff client

We remove the check on JSConsents content so that when cookie consent is
enabled we retain the option for users to get more information about
what cookies are being used.

Test plan
1) Enable CookieConsents
2) Do not add any tracking cookies for the staff client into
   CookieConsentedJS preference
3) Note that 'My consents' appears in the user menu
4) Clicking 'My consents' opens the 'Cookie consent' modal displaying
   information about the cookies used.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 11 Owen Leonard 2023-12-01 12:01:31 UTC
Created attachment 159446 [details] [review]
Bug 35348: Remove cookie consents link from opac consents

The cookies details modal is now visible for all users from a footer
link, we no longer need it under the 'Consents' tab for logged in users.

Test plan
1) Enable CookieConsent and add a placholder tracker cookie to
   CookieConsentedJS preference
2) Log into the OPAC
3) Note that the 'Consents' link no longer appears in the users page.
4) Enable 'PrivacyPolicyConsent'
5) Note that the 'Consents' link now appears but on navigating to it
   there is no link for Cookie consents.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 12 Martin Renvoize 2024-04-25 16:09:36 UTC
Created attachment 165568 [details] [review]
Bug 35348: Add cookies link to opac footer

This patch adds a link that opens the cookies info dialogue to the opac
footer when the CookieConsent feature is enabled.

Test plan
1) Enable CookieConsent
2) On the OPAC you should now see a 'Cookies' link at the bottom of the
   page.
3) Clicking the link should open the "Cookie consent" modal where you
   can see the details of the cookies you have accepted and change your
   choices.
4) Bonus points: Enable 'OpacProblemReports' and note it aligns left of
   'Cookies' in the same footer bar.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 13 Martin Renvoize 2024-04-25 16:09:39 UTC
Created attachment 165569 [details] [review]
Bug 35348: Ensure users can access cookie details in staff client

We remove the check on JSConsents content so that when cookie consent is
enabled we retain the option for users to get more information about
what cookies are being used.

Test plan
1) Enable CookieConsents
2) Do not add any tracking cookies for the staff client into
   CookieConsentedJS preference
3) Note that 'My consents' appears in the user menu
4) Clicking 'My consents' opens the 'Cookie consent' modal displaying
   information about the cookies used.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 14 Martin Renvoize 2024-04-25 16:09:41 UTC
Created attachment 165570 [details] [review]
Bug 35348: Remove cookie consents link from opac consents

The cookies details modal is now visible for all users from a footer
link, we no longer need it under the 'Consents' tab for logged in users.

Test plan
1) Enable CookieConsent and add a placholder tracker cookie to
   CookieConsentedJS preference
2) Log into the OPAC
3) Note that the 'Consents' link no longer appears in the users page.
4) Enable 'PrivacyPolicyConsent'
5) Note that the 'Consents' link now appears but on navigating to it
   there is no link for Cookie consents.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 15 Martin Renvoize 2024-04-25 16:10:29 UTC
Another rebase.. another bug they really aught to have gone in alongside the original cookie consent stuff.
Comment 16 Marcel de Rooy 2024-04-26 09:44:38 UTC
Created attachment 165632 [details] [review]
Bug 35348: Add cookies link to opac footer

This patch adds a link that opens the cookies info dialogue to the opac
footer when the CookieConsent feature is enabled.

Test plan
1) Enable CookieConsent
2) On the OPAC you should now see a 'Cookies' link at the bottom of the
   page.
3) Clicking the link should open the "Cookie consent" modal where you
   can see the details of the cookies you have accepted and change your
   choices.
4) Bonus points: Enable 'OpacProblemReports' and note it aligns left of
   'Cookies' in the same footer bar.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 17 Marcel de Rooy 2024-04-26 09:44:40 UTC
Created attachment 165633 [details] [review]
Bug 35348: Ensure users can access cookie details in staff client

We remove the check on JSConsents content so that when cookie consent is
enabled we retain the option for users to get more information about
what cookies are being used.

Test plan
1) Enable CookieConsents
2) Do not add any tracking cookies for the staff client into
   CookieConsentedJS preference
3) Note that 'My consents' appears in the user menu
4) Clicking 'My consents' opens the 'Cookie consent' modal displaying
   information about the cookies used.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 18 Marcel de Rooy 2024-04-26 09:44:43 UTC
Created attachment 165634 [details] [review]
Bug 35348: Remove cookie consents link from opac consents

The cookies details modal is now visible for all users from a footer
link, we no longer need it under the 'Consents' tab for logged in users.

Test plan
1) Enable CookieConsent and add a placholder tracker cookie to
   CookieConsentedJS preference
2) Log into the OPAC
3) Note that the 'Consents' link no longer appears in the users page.
4) Enable 'PrivacyPolicyConsent'
5) Note that the 'Consents' link now appears but on navigating to it
   there is no link for Cookie consents.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 19 Marcel de Rooy 2024-04-26 09:45:09 UTC
Not sure about major btw? Passing QA
Comment 20 Katrin Fischer 2024-04-26 15:06:46 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 21 Fridolin Somers 2024-05-22 12:34:19 UTC
Depends on Bug 35346 not in 23.11.x