Summary: | Accounting transactions do not show managing librarian if HidePatronName is set to yes | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Fines and fees | Assignee: | Sam Lau <samalau> |
Status: | Failed QA --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | laura, m.de.rooy, sally.healey, samalau |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status
Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status |
Description
Kelly McElligott
2024-01-30 14:23:47 UTC
Sorry, I meant if the library has the system preference, HidePatronName, set to Don't Show. ^^ Created attachment 167673 [details] [review] Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status This patch removes the 'hide_patron_infos_if_needed => 1' passing into 'patron-title.inc' from 'accountline-details.tt'. Doing so allows for the managing librarian to be shown in the accounting details. In order to correctly link to this librarian, necessary changes were also made to the 'patron-title.inc' 1) Set 'HidePatronName' sys. pref. to 'Don't show' 2) Go to a patron's page 3) Click on the accounting tab 4) Select 'Create manual invoice', put in an amount and press save. 5) In the transactions tab, click on the details of that specifc transaction 6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' 7) Apply patch, restart_all 8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. 9) Click on this name and make sure the link works 10) Go back to accounting section and now make a payment. 11) View details of this transaction and ensure the librarian is present Created attachment 173802 [details] [review] Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status This patch removes the 'hide_patron_infos_if_needed => 1' passing into 'patron-title.inc' from 'accountline-details.tt'. Doing so allows for the managing librarian to be shown in the accounting details. In order to correctly link to this librarian, necessary changes were also made to the 'patron-title.inc' 1) Set 'HidePatronName' sys. pref. to 'Don't show' 2) Go to a patron's page 3) Click on the accounting tab 4) Select 'Create manual invoice', put in an amount and press save. 5) In the transactions tab, click on the details of that specifc transaction 6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' 7) Apply patch, restart_all 8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. 9) Click on this name and make sure the link works 10) Go back to accounting section and now make a payment. 11) View details of this transaction and ensure the librarian is present Signed-off-by: Laura ONeil <laura@bywatersolutions.com> -[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] +[%- IF ( display_patron_name OR display_cardnumber ) -%] -[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] +[%- IF ( display_patron_name OR display_cardnumber ) -%] Changes in patron-title.inc affect a lot of places. So removing that check here seems wrong. Please prove me wrong. |