Summary: | Printing list from OPAC shows "Cookies" when CookieConsent enabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Mirjam Vantieghem <mirjam.vantieghem> |
Component: | Lists | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | RESOLVED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes an issue with printing lists. If the CookieConsent system preference was set to "Required", printing a list from the OPAC resulted in the word "Cookies" appearing at the bottom left on the last page, under the last result.
|
Version(s) released in: |
24.05.00
|
Circulation function: | |||
Bug Depends on: | 35348 | ||
Bug Blocks: | |||
Attachments: |
Bug 36003: Add cookie consent buttons to hidden list on print
Bug 36003: Add cookie consent buttons to hidden list on print Bug 36003: Add cookie consent buttons to hidden list on print |
Description
Mirjam Vantieghem
2024-02-06 14:01:30 UTC
Created attachment 161801 [details] [review] Bug 36003: Add cookie consent buttons to hidden list on print This patch adds #consentMoreInfo, #cookieConsentFooter and .consentAcceptEssential to the hidden fields for OPAC printing. Created attachment 162001 [details] [review] Bug 36003: Add cookie consent buttons to hidden list on print This patch adds #consentMoreInfo, #cookieConsentFooter and .consentAcceptEssential to the hidden fields for OPAC printing. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using koha-testing-docker): 1. Set the CookieConsent system preference to required. 2. Create a public list and add some items. 3. Go to the OPAC and view the list (don't log in, or click the 'Accept all cookies' prompt in the footer). 4. Print the list. 5. Note that "Accept all cookies" is printed near the bottom of the page. 6. Apply the patch. 7. Rebuild the CSS: yarn build 8. Restart everything: reset_all 9. Refresh the list page and print the list again - it should now not show "Accept all cookies" near the bottom of the page. Whole bunch of deps in PQA and SO too. Skipping for now. Created attachment 166120 [details] [review] Bug 36003: Add cookie consent buttons to hidden list on print This patch adds #consentMoreInfo, #cookieConsentFooter and .consentAcceptEssential to the hidden fields for OPAC printing. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! No updates required to the manual - this fixes an issue with the output from printing a list, |