Bug 36003 - Printing list from OPAC shows "Cookies" when CookieConsent enabled
Summary: Printing list from OPAC shows "Cookies" when CookieConsent enabled
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Martin Renvoize (ashimema)
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on: 35348
Blocks:
  Show dependency tree / graph
 
Reported: 2024-02-06 14:01 UTC by Mirjam Vantieghem
Modified: 2024-08-03 18:41 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes an issue with printing lists. If the CookieConsent system preference was set to "Required", printing a list from the OPAC resulted in the word "Cookies" appearing at the bottom left on the last page, under the last result.
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36003: Add cookie consent buttons to hidden list on print (1007 bytes, patch)
2024-02-07 13:38 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 36003: Add cookie consent buttons to hidden list on print (1.03 KB, patch)
2024-02-10 03:07 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36003: Add cookie consent buttons to hidden list on print (1.09 KB, patch)
2024-05-03 13:38 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mirjam Vantieghem 2024-02-06 14:01:30 UTC 
If system preference CookieConsent is set to "Required", the word "Cookies" appears at the bottem left on the last page, under the last result, when printing a list from the OPAC. Funny, but not desirable.
Not sure if similar to bug #12260.
Comment 1 Martin Renvoize (ashimema) 2024-02-07 13:38:16 UTC 
Created attachment 161801 [details] [review]
Bug 36003: Add cookie consent buttons to hidden list on print

This patch adds #consentMoreInfo, #cookieConsentFooter and
.consentAcceptEssential to the hidden fields for OPAC printing.
Comment 2 David Nind 2024-02-10 03:07:51 UTC 
Created attachment 162001 [details] [review]
Bug 36003: Add cookie consent buttons to hidden list on print

This patch adds #consentMoreInfo, #cookieConsentFooter and
.consentAcceptEssential to the hidden fields for OPAC printing.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-02-10 03:09:45 UTC 
Testing notes (using koha-testing-docker):

1. Set the CookieConsent system preference to required.
2. Create a public list and add some items.
3. Go to the OPAC and view the list (don't log in, or click the 'Accept all cookies' prompt in the footer).
4. Print the list.
5. Note that "Accept all cookies" is printed near the bottom of the page.
6. Apply the patch.
7. Rebuild the CSS: yarn build
8. Restart everything: reset_all
9. Refresh the list page and print the list again - it should now not show "Accept all cookies" near the bottom of the page.
Comment 4 Marcel de Rooy 2024-03-01 10:48:32 UTC 
Whole bunch of deps in PQA and SO too. Skipping for now.
Comment 5 Kyle M Hall (khall) 2024-05-03 13:38:05 UTC 
Created attachment 166120 [details] [review]
Bug 36003: Add cookie consent buttons to hidden list on print

This patch adds #consentMoreInfo, #cookieConsentFooter and
.consentAcceptEssential to the hidden fields for OPAC printing.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Katrin Fischer 2024-05-03 14:03:48 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-24 13:07:40 UTC 
Depends on Bug 35348 not in 23.11.x
Comment 8 David Nind 2024-08-03 18:41:29 UTC 
No updates required to the manual - this fixes an issue with the output from printing a list,