Bug 36408

Summary: Move boraccount.tt modals to includes/modals/
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Architecture, internals, and plumbingAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED INVALID QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: andrew
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 24597    
Attachments: Bug 36408: Move issue payout modal to include
Bug 36408: Move issue refund modal to include
Bug 36408: Move apply discount modal to include

Description Lucas Gass (lukeg) 2024-03-22 19:40:11 UTC
There are 3 modals on the boraccount.tt page which should be moved into the modals directory and included from there: 

-Issue payout modal
- Issue refund modal
-Apply discount modal
Comment 1 Lucas Gass (lukeg) 2024-03-22 19:48:32 UTC
Created attachment 163738 [details] [review]
Bug 36408: Move issue payout modal to include

To test:
1. APPLY PATCH
2. Go to the transaction tab on a patron account and "Create manual credit"
3. Now go to the transaction page and look for the "Payout amount" button
4. Make sure the modal loads properly and you can make a full payout and a partial payout.
5. Turn on "UseCashRegisters" and make a new register.
6. Ensure you can select the register correctly when paying out.
Comment 2 Lucas Gass (lukeg) 2024-03-22 20:03:13 UTC
Created attachment 163739 [details] [review]
Bug 36408: Move issue refund modal to include

To test:
1. APPLY PATCH
2. Go to the transaction tab on a patron account and "Create manual invoice".
3. Pay it.
4. Go to the transaction tab on a patron account and look for the "Issue refund" button.
5. Make sure the modal loads and properly and you make a full refund and a patrion one.
6. Turn on "UseCashRegisters" and make a new register.
7. Ensure you can select the register correctly when issuing a refund.
Comment 3 Lucas Gass (lukeg) 2024-03-22 20:17:20 UTC
Created attachment 163740 [details] [review]
Bug 36408: Move apply discount modal to include

To test:
1. APPLY PATCH
2. Go to the transaction tab on a patron account and "Create manual invoice".
3. Now go to the transaction tab for that patron and attempt to apply a discount.
4. Make sure the modal loads properly and you are able to apply the discount.
Comment 4 Andrew Fuerste-Henry 2024-04-12 20:51:06 UTC
With these patches applied the Apply Discount button didn't do anything at all when clicked.