Bug 36408 - Move boraccount.tt modals to includes/modals/
Summary: Move boraccount.tt modals to includes/modals/
Status: RESOLVED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 24597
  Show dependency treegraph
 
Reported: 2024-03-22 19:40 UTC by Lucas Gass (lukeg)
Modified: 2024-06-27 14:39 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 36408: Move issue payout modal to include (8.44 KB, patch)
2024-03-22 19:48 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 36408: Move issue refund modal to include (8.60 KB, patch)
2024-03-22 20:03 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 36408: Move apply discount modal to include (6.34 KB, patch)
2024-03-22 20:17 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-03-22 19:40:11 UTC
There are 3 modals on the boraccount.tt page which should be moved into the modals directory and included from there: 

-Issue payout modal
- Issue refund modal
-Apply discount modal
Comment 1 Lucas Gass (lukeg) 2024-03-22 19:48:32 UTC
Created attachment 163738 [details] [review]
Bug 36408: Move issue payout modal to include

To test:
1. APPLY PATCH
2. Go to the transaction tab on a patron account and "Create manual credit"
3. Now go to the transaction page and look for the "Payout amount" button
4. Make sure the modal loads properly and you can make a full payout and a partial payout.
5. Turn on "UseCashRegisters" and make a new register.
6. Ensure you can select the register correctly when paying out.
Comment 2 Lucas Gass (lukeg) 2024-03-22 20:03:13 UTC
Created attachment 163739 [details] [review]
Bug 36408: Move issue refund modal to include

To test:
1. APPLY PATCH
2. Go to the transaction tab on a patron account and "Create manual invoice".
3. Pay it.
4. Go to the transaction tab on a patron account and look for the "Issue refund" button.
5. Make sure the modal loads and properly and you make a full refund and a patrion one.
6. Turn on "UseCashRegisters" and make a new register.
7. Ensure you can select the register correctly when issuing a refund.
Comment 3 Lucas Gass (lukeg) 2024-03-22 20:17:20 UTC
Created attachment 163740 [details] [review]
Bug 36408: Move apply discount modal to include

To test:
1. APPLY PATCH
2. Go to the transaction tab on a patron account and "Create manual invoice".
3. Now go to the transaction tab for that patron and attempt to apply a discount.
4. Make sure the modal loads properly and you are able to apply the discount.
Comment 4 Andrew Fuerste-Henry 2024-04-12 20:51:06 UTC
With these patches applied the Apply Discount button didn't do anything at all when clicked.