Bug 36693

Summary: Improve floating toolbar in OPAC search results
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: OPACAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED WORKSFORME QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: barbara.johnson, david
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 36694    
Bug Blocks:    
Attachments: Bug 36693: Remove hc-sticky and use CSS sticky
Bug 36693: Add background color to OPAC floating element
Bug 36693: Add background color to OPAC floating element

Description Lucas Gass (lukeg) 2024-04-24 22:01:14 UTC
I think the floating toolbar ( #floating ) can be slightly improved.

-Between the #toolbar and the .selections-toolbar there is a small space and one can see the content beneath it. Slight annoyance

-I think we can use position: sticky now to accomplish the "floating". It seems to have widespread enough support:

https://caniuse.com/?search=sticky
Comment 1 Lucas Gass (lukeg) 2024-04-24 22:10:51 UTC
Created attachment 165488 [details] [review]
Bug 36693: Remove hc-sticky and use CSS sticky

To test:
1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. DO an OPAC search that has enough results to scroll.
3. The toolbar which includes pagination, select all, clear all, etc. should scoll the same as it did without the patch.
4. There should no longer be a small gap between the pagination and the other tools.
Comment 2 Lucas Gass (lukeg) 2024-04-26 18:07:58 UTC
I took care of the removal of HC stick in Bug 36694. I will use this one to remove the small gap that you can see through in the #floating element.
Comment 3 David Nind 2024-04-26 20:17:10 UTC
Changed status to assigned, as there is nothing to sign off yet 8-).

I can confirm the behavour mentioned in current main - a small space and can see the content beneath it.
Comment 4 Lucas Gass (lukeg) 2024-04-29 17:11:28 UTC
Created attachment 165768 [details] [review]
Bug 36693: Add background color to OPAC floating element

To test:
1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. DO an OPAC search that has enough results to scroll.
3. There should no longer be a small gap between the pagination and the other tools.
Comment 5 ByWater Sandboxes 2024-04-29 18:13:01 UTC
Created attachment 165795 [details] [review]
Bug 36693: Add background color to OPAC floating element

To test:
1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. DO an OPAC search that has enough results to scroll.
3. There should no longer be a small gap between the pagination and the other tools.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 6 Martin Renvoize (ashimema) 2024-05-13 10:23:32 UTC
Dependency in FQA state, marking as blocked.
Comment 7 Lucas Gass (lukeg) 2024-11-05 17:13:41 UTC
Dependency is pushed to main. Setting this one to NSO.
Comment 8 Owen Leonard 2024-11-06 12:20:31 UTC
Does this issue still exist in main?
Comment 9 Lucas Gass (lukeg) 2024-11-06 13:55:16 UTC
(In reply to Owen Leonard from comment #8)
> Does this issue still exist in main?

It doesn't appear so. I cant track down where it was fixed, maybe during Bootstrap 5 updates? Either way, I'll close this report.