I think the floating toolbar ( #floating ) can be slightly improved. -Between the #toolbar and the .selections-toolbar there is a small space and one can see the content beneath it. Slight annoyance -I think we can use position: sticky now to accomplish the "floating". It seems to have widespread enough support: https://caniuse.com/?search=sticky
Created attachment 165488 [details] [review] Bug 36693: Remove hc-sticky and use CSS sticky To test: 1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. DO an OPAC search that has enough results to scroll. 3. The toolbar which includes pagination, select all, clear all, etc. should scoll the same as it did without the patch. 4. There should no longer be a small gap between the pagination and the other tools.
I took care of the removal of HC stick in Bug 36694. I will use this one to remove the small gap that you can see through in the #floating element.
Changed status to assigned, as there is nothing to sign off yet 8-). I can confirm the behavour mentioned in current main - a small space and can see the content beneath it.
Created attachment 165768 [details] [review] Bug 36693: Add background color to OPAC floating element To test: 1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. DO an OPAC search that has enough results to scroll. 3. There should no longer be a small gap between the pagination and the other tools.
Created attachment 165795 [details] [review] Bug 36693: Add background color to OPAC floating element To test: 1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. DO an OPAC search that has enough results to scroll. 3. There should no longer be a small gap between the pagination and the other tools. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Dependency in FQA state, marking as blocked.
Dependency is pushed to main. Setting this one to NSO.
Does this issue still exist in main?
(In reply to Owen Leonard from comment #8) > Does this issue still exist in main? It doesn't appear so. I cant track down where it was fixed, maybe during Bootstrap 5 updates? Either way, I'll close this report.