| Summary: | Tagging: Resolve warning about unrecognized biblionumber | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | OPAC | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 36785: Do not pass biblionumber to get_approval_rows
Bug 36785: Typo unreconized and bilbio in tags code Bug 36785: Do not pass biblionumber to get_approval_rows Bug 36785: Typo unreconized and bilbio in tags code |
||
|
Description
Marcel de Rooy
2024-05-06 08:53:21 UTC
Created attachment 166188 [details] [review] Bug 36785: Do not pass biblionumber to get_approval_rows Resolve: [WARN] get_approval_rows received unreconized argument key 'biblionumber'. at /usr/share/koha/opac/opac-tags.pl line 336. Test plan: Visit opac-tags.pl?biblionumber=SOME_NUMBER With this patch, you should no longer find a warning in the logs. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 166189 [details] [review] Bug 36785: Typo unreconized and bilbio in tags code Test plan: Look at the patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial: Self SO Created attachment 166755 [details] [review] Bug 36785: Do not pass biblionumber to get_approval_rows Resolve: [WARN] get_approval_rows received unreconized argument key 'biblionumber'. at /usr/share/koha/opac/opac-tags.pl line 336. Test plan: Visit opac-tags.pl?biblionumber=SOME_NUMBER With this patch, you should no longer find a warning in the logs. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 166756 [details] [review] Bug 36785: Typo unreconized and bilbio in tags code Test plan: Look at the patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Does this need to be backported to 23.05.x? |